starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #21000] [MERGED] Fixes #20011: Provide accurate error for bulk import duplicate IDs #16114

New Issue
Closed
opened 2025-12-30 00:25:52 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:25:52 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/21000
Author: @jnovinger
Created: 12/17/2025
Status: ✅ Merged
Merged: 12/22/2025
Merged by: @bctiemann

Base: main ← Head: 20011-misleading-error-message

📝 Commits (1)

  • d95fa8d Fixes #20011: UI Error msg for duplicate IDs in bulk import

📊 Changes

2 files changed (+40 additions, -0 deletions)

View changed files

📝 netbox/dcim/tests/test_views.py (+26 -0)
📝 netbox/netbox/views/generic/bulk_views.py (+14 -0)

📄 Description

Fixes: #20011

  • BulkImportView.create_and_update_objects() now checks for duplicate IDs and returns a more useful error message
  • Chose not to implement extra logging, as original report requested, as it is inconsistent with current logging approach for bulk views. If we need to change this, a new FR should be filed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/21000 **Author:** [@jnovinger](https://github.com/jnovinger) **Created:** 12/17/2025 **Status:** ✅ Merged **Merged:** 12/22/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `main` ← **Head:** `20011-misleading-error-message` --- ### 📝 Commits (1) - [`d95fa8d`](https://github.com/netbox-community/netbox/commit/d95fa8dbb23f291742bc81a9e0d3a036c0eba6d1) Fixes #20011: UI Error msg for duplicate IDs in bulk import ### 📊 Changes **2 files changed** (+40 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/tests/test_views.py` (+26 -0) 📝 `netbox/netbox/views/generic/bulk_views.py` (+14 -0) </details> ### 📄 Description ### Fixes: #20011 - `BulkImportView.create_and_update_objects()` now checks for duplicate IDs and returns a more useful error message - Chose not to implement extra logging, as original report requested, as it is inconsistent with current logging approach for bulk views. If we need to change this, a new FR should be filed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:25:52 +01:00
adam closed this issue 2025-12-30 00:25:52 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#16114
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?