starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20958] [MERGED] Fixes #17976: Remove devicetype_count from nested manufacturer to correct OpenAPI schema #16099

New Issue
Closed
opened 2025-12-30 00:25:47 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:25:47 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20958
Author: @jeremystretch
Created: 12/10/2025
Status: ✅ Merged
Merged: 12/12/2025
Merged by: @bctiemann

Base: main ← Head: 17976-manufacturer-devicetype_count

📝 Commits (2)

  • 14b246c Fixes #17976: Remove devicetype_count from nested manufacturer to correct OpenAPI schema
  • 59afa0b Fix test

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 netbox/dcim/api/serializers_/manufacturers.py (+1 -1)
📝 netbox/dcim/tests/test_api.py (+1 -1)

📄 Description

Fixes: #17976

  • Remove the devicetype_count field from brief_fields for the Manufacturer serializer

I'm not sure why this was ever included initially; it appears to be an oversight. The model's other counter fields (inventoryitem_count and platform_count) are not included.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20958 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 12/10/2025 **Status:** ✅ Merged **Merged:** 12/12/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `main` ← **Head:** `17976-manufacturer-devicetype_count` --- ### 📝 Commits (2) - [`14b246c`](https://github.com/netbox-community/netbox/commit/14b246cb8acc2bc6ce171fcc9dbd727b0ab7e15f) Fixes #17976: Remove devicetype_count from nested manufacturer to correct OpenAPI schema - [`59afa0b`](https://github.com/netbox-community/netbox/commit/59afa0b41d4fbf2b03f2415b4fe497b08ee4675c) Fix test ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/api/serializers_/manufacturers.py` (+1 -1) 📝 `netbox/dcim/tests/test_api.py` (+1 -1) </details> ### 📄 Description ### Fixes: #17976 - Remove the `devicetype_count` field from `brief_fields` for the Manufacturer serializer I'm not sure why this was ever included initially; it appears to be an oversight. The model's other counter fields (`inventoryitem_count` and `platform_count`) are not included. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:25:47 +01:00
adam closed this issue 2025-12-30 00:25:47 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#16099
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?