starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20951] [MERGED] Add comments to OrganizationalModel #16098

New Issue
Closed
opened 2025-12-30 00:25:47 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:25:47 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20951
Author: @arthanson
Created: 12/8/2025
Status: ✅ Merged
Merged: 12/12/2025
Merged by: @bctiemann

Base: feature ← Head: 20925-comments-oranizationalmodel

📝 Commits (8)

  • e910d46 Add comments to OrganizationalModel
  • 7bf84eb update fields
  • 27ffc3d add to detail view templates
  • 113c8b7 merge feature
  • 4e0265a fix manufactuers detail view
  • dc09ec3 fix rackrole detail view
  • 834da4e Merge branch 'feature' into 20925-comments-oranizationalmodel
  • 607a385 Fix style

📊 Changes

67 files changed (+283 additions, -82 deletions)

View changed files

📝 netbox/circuits/api/serializers_/circuits.py (+3 -3)
📝 netbox/circuits/forms/bulk_edit.py (+3 -3)
📝 netbox/circuits/forms/bulk_import.py (+3 -3)
📝 netbox/circuits/forms/model_forms.py (+3 -3)
➕ netbox/circuits/migrations/0055_add_comments_to_organizationalmodel.py (+28 -0)
📝 netbox/circuits/search.py (+3 -0)
📝 netbox/circuits/tables/circuits.py (+3 -3)
📝 netbox/dcim/api/serializers_/manufacturers.py (+3 -2)
📝 netbox/dcim/api/serializers_/racks.py (+1 -1)
📝 netbox/dcim/api/serializers_/roles.py (+1 -1)
📝 netbox/dcim/forms/bulk_edit.py (+3 -3)
📝 netbox/dcim/forms/bulk_import.py (+3 -3)
📝 netbox/dcim/forms/model_forms.py (+3 -3)
➕ netbox/dcim/migrations/0224_add_comments_to_organizationalmodel.py (+28 -0)
📝 netbox/dcim/search.py (+14 -0)
📝 netbox/dcim/tables/devices.py (+1 -1)
📝 netbox/dcim/tables/devicetypes.py (+2 -1)
📝 netbox/dcim/tables/racks.py (+1 -1)
📝 netbox/dcim/views.py (+2 -1)
📝 netbox/ipam/api/serializers_/asns.py (+3 -3)

...and 47 more files

📄 Description

Fixes: #20925

Adds comments to OrganizationalModel, updates model form, bulk-edit, import, detail view, REST API and GraphQL API where needed.

  • circuitgroup
    • edit / detail view
    • Configure Table
    • bulk edit
    • import
    • REST
    • GraphQL
  • circuittype
    • edit / detail view
    • Configure Table
    • bulk edit
    • import
    • REST
    • GraphQL
  • virtualcircuittype
    • edit / detail view
    • Configure Table
    • bulk edit
    • import
    • REST
    • GraphQL
  • inventoryitemrole
    • edit / detail view
    • Configure Table
    • bulk edit
    • import
    • REST
    • GraphQL
  • manufacturer
    • edit / detail view
    • Configure Table
    • bulk edit
    • import
    • REST
    • GraphQL
  • rackrole
    • edit / detail view
    • Configure Table
    • bulk edit
    • import
    • REST
    • GraphQL
  • asnrange
    • edit / detail view
    • Configure Table
    • bulk edit
    • import
    • REST
    • GraphQL
  • rir
    • edit / detail view
    • Configure Table
    • bulk edit
    • import
    • REST
    • GraphQL
  • role (VLAN Role)
    • edit / detail view
    • Configure Table
    • bulk edit
    • import
    • REST
    • GraphQL
  • vlangroup
    • edit / detail view
    • Configure Table
    • bulk edit
    • import
    • REST
    • GraphQL
  • contactrole
    • edit / detail view
    • Configure Table
    • bulk edit
    • import
    • REST
    • GraphQL
  • clustergroup
    • edit / detail view
    • Configure Table
    • bulk edit
    • import
    • REST
    • GraphQL
  • clustertype
    • edit / detail view
    • Configure Table
    • bulk edit
    • import
    • REST
    • GraphQL
  • tunnelgroup
    • edit / detail view
    • Configure Table
    • bulk edit
    • import
    • REST
    • GraphQL

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20951 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 12/8/2025 **Status:** ✅ Merged **Merged:** 12/12/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `feature` ← **Head:** `20925-comments-oranizationalmodel` --- ### 📝 Commits (8) - [`e910d46`](https://github.com/netbox-community/netbox/commit/e910d461ea9e4af7e54ad81871c2a9f1758aac88) Add comments to OrganizationalModel - [`7bf84eb`](https://github.com/netbox-community/netbox/commit/7bf84eb4004bc220a2a0a5346238ae3c64e652ea) update fields - [`27ffc3d`](https://github.com/netbox-community/netbox/commit/27ffc3df6afd5dec374c132531b427ddd047ca18) add to detail view templates - [`113c8b7`](https://github.com/netbox-community/netbox/commit/113c8b7ae6c8eab490483aa0b646640cf7f1e98b) merge feature - [`4e0265a`](https://github.com/netbox-community/netbox/commit/4e0265a001c86826b88d73fca6853dc3f2ffeeb8) fix manufactuers detail view - [`dc09ec3`](https://github.com/netbox-community/netbox/commit/dc09ec30254d1c8a24e4aaf6ed098d5ec3da720b) fix rackrole detail view - [`834da4e`](https://github.com/netbox-community/netbox/commit/834da4e6cd11d2534b6961697897a06cd61ea806) Merge branch 'feature' into 20925-comments-oranizationalmodel - [`607a385`](https://github.com/netbox-community/netbox/commit/607a385a1205b05499ba9a72bdeef1e88859cc26) Fix style ### 📊 Changes **67 files changed** (+283 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/api/serializers_/circuits.py` (+3 -3) 📝 `netbox/circuits/forms/bulk_edit.py` (+3 -3) 📝 `netbox/circuits/forms/bulk_import.py` (+3 -3) 📝 `netbox/circuits/forms/model_forms.py` (+3 -3) ➕ `netbox/circuits/migrations/0055_add_comments_to_organizationalmodel.py` (+28 -0) 📝 `netbox/circuits/search.py` (+3 -0) 📝 `netbox/circuits/tables/circuits.py` (+3 -3) 📝 `netbox/dcim/api/serializers_/manufacturers.py` (+3 -2) 📝 `netbox/dcim/api/serializers_/racks.py` (+1 -1) 📝 `netbox/dcim/api/serializers_/roles.py` (+1 -1) 📝 `netbox/dcim/forms/bulk_edit.py` (+3 -3) 📝 `netbox/dcim/forms/bulk_import.py` (+3 -3) 📝 `netbox/dcim/forms/model_forms.py` (+3 -3) ➕ `netbox/dcim/migrations/0224_add_comments_to_organizationalmodel.py` (+28 -0) 📝 `netbox/dcim/search.py` (+14 -0) 📝 `netbox/dcim/tables/devices.py` (+1 -1) 📝 `netbox/dcim/tables/devicetypes.py` (+2 -1) 📝 `netbox/dcim/tables/racks.py` (+1 -1) 📝 `netbox/dcim/views.py` (+2 -1) 📝 `netbox/ipam/api/serializers_/asns.py` (+3 -3) _...and 47 more files_ </details> ### 📄 Description ### Fixes: #20925 Adds comments to OrganizationalModel, updates model form, bulk-edit, import, detail view, REST API and GraphQL API where needed. - [x] circuitgroup - [x] edit / detail view - [x] Configure Table - [x] bulk edit - [x] import - [x] REST - [x] GraphQL - [x] circuittype - [x] edit / detail view - [x] Configure Table - [x] bulk edit - [x] import - [x] REST - [x] GraphQL - [x] virtualcircuittype - [x] edit / detail view - [x] Configure Table - [x] bulk edit - [x] import - [x] REST - [x] GraphQL - [x] inventoryitemrole - [x] edit / detail view - [x] Configure Table - [x] bulk edit - [x] import - [x] REST - [x] GraphQL - [x] manufacturer - [x] edit / detail view - [x] Configure Table - [x] bulk edit - [x] import - [x] REST - [x] GraphQL - [x] rackrole - [x] edit / detail view - [x] Configure Table - [x] bulk edit - [x] import - [x] REST - [x] GraphQL - [x] asnrange - [x] edit / detail view - [x] Configure Table - [x] bulk edit - [x] import - [x] REST - [x] GraphQL - [x] rir - [x] edit / detail view - [x] Configure Table - [x] bulk edit - [x] import - [x] REST - [x] GraphQL - [x] role (VLAN Role) - [x] edit / detail view - [x] Configure Table - [x] bulk edit - [x] import - [x] REST - [x] GraphQL - [x] vlangroup - [x] edit / detail view - [x] Configure Table - [x] bulk edit - [x] import - [x] REST - [x] GraphQL - [x] contactrole - [x] edit / detail view - [x] Configure Table - [x] bulk edit - [x] import - [x] REST - [x] GraphQL - [x] clustergroup - [x] edit / detail view - [x] Configure Table - [x] bulk edit - [x] import - [x] REST - [x] GraphQL - [x] clustertype - [x] edit / detail view - [x] Configure Table - [x] bulk edit - [x] import - [x] REST - [x] GraphQL - [x] tunnelgroup - [x] edit / detail view - [x] Configure Table - [x] bulk edit - [x] import - [x] REST - [x] GraphQL --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:25:47 +01:00
adam closed this issue 2025-12-30 00:25:47 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#16098
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?