starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20955] [MERGED] #20873 - fix webhooks with image fields #16096

New Issue
Closed
opened 2025-12-30 00:25:46 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:25:46 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20955
Author: @arthanson
Created: 12/10/2025
Status: ✅ Merged
Merged: 12/10/2025
Merged by: @jnovinger

Base: main ← Head: 20873-image

📝 Commits (1)

📊 Changes

2 files changed (+14 additions, -5 deletions)

View changed files

📝 netbox/extras/events.py (+3 -1)
📝 netbox/utilities/request.py (+11 -4)

📄 Description

Fixes: #20873

Fixes event rules where the models have submitted files. The issue is the FILES param was getting the file objects which weren't pickleable due to a quirk in Pillow, Files are not needed for the event code anyways. Fix was to exclude these from copy_safe_request function.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20955 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 12/10/2025 **Status:** ✅ Merged **Merged:** 12/10/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `main` ← **Head:** `20873-image` --- ### 📝 Commits (1) - [`12a8e60`](https://github.com/netbox-community/netbox/commit/12a8e60aff52379f86ff03110209990ae7e10032) #20873 - fix webhooks with image fields ### 📊 Changes **2 files changed** (+14 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/events.py` (+3 -1) 📝 `netbox/utilities/request.py` (+11 -4) </details> ### 📄 Description ### Fixes: #20873 Fixes event rules where the models have submitted files. The issue is the FILES param was getting the file objects which weren't pickleable due to a quirk in Pillow, Files are not needed for the event code anyways. Fix was to exclude these from copy_safe_request function. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:25:46 +01:00
adam closed this issue 2025-12-30 00:25:46 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#16096
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?