starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20935] [MERGED] Closes #20926: Rename and clean up GraphQL filters #16090

New Issue
Closed
opened 2025-12-30 00:25:43 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:25:43 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20935
Author: @jeremystretch
Created: 12/5/2025
Status: ✅ Merged
Merged: 12/8/2025
Merged by: @jnovinger

Base: feature ← Head: 20926-rename-graphql-filters

📝 Commits (6)

  • dd11bda Rename base filter classes & move to netbox.graphql.filters
  • 19e056b Rename BaseObjectTypeFilterMixin to BaseModelFilter; remove from mixins
  • bfab461 Move changelogging filters to ChangeLoggingMixin
  • 69057dd Refactor filter mixins
  • 6c8dece Misc cleanup
  • fd8f37d Correct base models for some device component filters

📊 Changes

21 files changed (+267 additions, -292 deletions)

View changed files

📝 docs/plugins/development/migration-v4.md (+3 -4)
📝 netbox/circuits/graphql/filter_mixins.py (+6 -5)
📝 netbox/circuits/graphql/filters.py (+14 -24)
📝 netbox/core/graphql/filter_mixins.py (+3 -16)
📝 netbox/core/graphql/filters.py (+5 -9)
📝 netbox/dcim/graphql/filter_mixins.py (+10 -12)
📝 netbox/dcim/graphql/filters.py (+63 -56)
📝 netbox/extras/graphql/filter_mixins.py (+4 -14)
📝 netbox/extras/graphql/filters.py (+20 -18)
📝 netbox/ipam/graphql/filter_mixins.py (+4 -5)
📝 netbox/ipam/graphql/filters.py (+22 -21)
📝 netbox/netbox/graphql/filter_mixins.py (+4 -48)
➕ netbox/netbox/graphql/filters.py (+61 -0)
📝 netbox/tenancy/graphql/filter_mixins.py (+2 -4)
📝 netbox/tenancy/graphql/filters.py (+8 -11)
📝 netbox/users/graphql/filters.py (+5 -5)
📝 netbox/virtualization/graphql/filter_mixins.py (+2 -4)
📝 netbox/virtualization/graphql/filters.py (+8 -11)
📝 netbox/vpn/graphql/filters.py (+13 -14)
📝 netbox/wireless/graphql/filter_mixins.py (+2 -4)

...and 1 more files

📄 Description

Closes: #20926

  • Standardized on the use of GraohQL filter base classes (in netbox.graphql.filters) corresponding to the base model classes
  • Renamed and moved all supplementary mixin classes to filter_mixins.py within each app

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20935 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 12/5/2025 **Status:** ✅ Merged **Merged:** 12/8/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `feature` ← **Head:** `20926-rename-graphql-filters` --- ### 📝 Commits (6) - [`dd11bda`](https://github.com/netbox-community/netbox/commit/dd11bdafee581ba3feb6ab9ac5ed643dfd1f52bd) Rename base filter classes & move to netbox.graphql.filters - [`19e056b`](https://github.com/netbox-community/netbox/commit/19e056bf8e4dd39dcaf0baa5bc87d6cf2c4714b6) Rename BaseObjectTypeFilterMixin to BaseModelFilter; remove from mixins - [`bfab461`](https://github.com/netbox-community/netbox/commit/bfab461e43272271932fb468610ce7ca383eca03) Move changelogging filters to ChangeLoggingMixin - [`69057dd`](https://github.com/netbox-community/netbox/commit/69057dd02c92a2ec5f29351a0e33f9ccb461c133) Refactor filter mixins - [`6c8dece`](https://github.com/netbox-community/netbox/commit/6c8dece4afb87dd6966c2e41b1262f86fe675046) Misc cleanup - [`fd8f37d`](https://github.com/netbox-community/netbox/commit/fd8f37dfe8ae1d0aeb329df43936451814c499ce) Correct base models for some device component filters ### 📊 Changes **21 files changed** (+267 additions, -292 deletions) <details> <summary>View changed files</summary> 📝 `docs/plugins/development/migration-v4.md` (+3 -4) 📝 `netbox/circuits/graphql/filter_mixins.py` (+6 -5) 📝 `netbox/circuits/graphql/filters.py` (+14 -24) 📝 `netbox/core/graphql/filter_mixins.py` (+3 -16) 📝 `netbox/core/graphql/filters.py` (+5 -9) 📝 `netbox/dcim/graphql/filter_mixins.py` (+10 -12) 📝 `netbox/dcim/graphql/filters.py` (+63 -56) 📝 `netbox/extras/graphql/filter_mixins.py` (+4 -14) 📝 `netbox/extras/graphql/filters.py` (+20 -18) 📝 `netbox/ipam/graphql/filter_mixins.py` (+4 -5) 📝 `netbox/ipam/graphql/filters.py` (+22 -21) 📝 `netbox/netbox/graphql/filter_mixins.py` (+4 -48) ➕ `netbox/netbox/graphql/filters.py` (+61 -0) 📝 `netbox/tenancy/graphql/filter_mixins.py` (+2 -4) 📝 `netbox/tenancy/graphql/filters.py` (+8 -11) 📝 `netbox/users/graphql/filters.py` (+5 -5) 📝 `netbox/virtualization/graphql/filter_mixins.py` (+2 -4) 📝 `netbox/virtualization/graphql/filters.py` (+8 -11) 📝 `netbox/vpn/graphql/filters.py` (+13 -14) 📝 `netbox/wireless/graphql/filter_mixins.py` (+2 -4) _...and 1 more files_ </details> ### 📄 Description ### Closes: #20926 - Standardized on the use of GraohQL filter base classes (in `netbox.graphql.filters`) corresponding to the base model classes - Renamed and moved all supplementary mixin classes to `filter_mixins.py` within each app --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:25:43 +01:00
adam closed this issue 2025-12-30 00:25:44 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#16090
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?