[PR #20783] [MERGED] Fixes #20660: Optimize loading of custom script modules from remote storage #16050

New Issue

adam · 2025-12-30T00:25:31+01:00

adam commented

2025-12-30 00:25:31 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20783
Author: @jeremystretch
Created: 11/10/2025
Status: ✅ Merged
Merged: 11/11/2025
Merged by: @jnovinger

Base: main ← Head: 20660-script-loading-time

📝 Commits (1)

54bc239 Fixes #20660: Optimize loading of custom script modules from remote storage

📊 Changes

2 files changed (+2 additions, -3 deletions)

View changed files

📝 netbox/extras/models/mixins.py (+1 -2)
📝 netbox/extras/models/scripts.py (+1 -1)

📄 Description

Fixes: #20660

Tweak exec_module() to avoid forcing the creation of a new storage connection on each call
Convert module_scripts to a cached property, to avoid triggering a new fetch for each script within a module file

Some quick testing using three modules comprising five total scripts shows total rendering time for the script list view reduced from ~4.15s to ~0.80s. There is still some linear increment per script module, as each file must be fetched from remote storage, but it should be greatly reduced.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20783 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 11/10/2025 **Status:** ✅ Merged **Merged:** 11/11/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `main` ← **Head:** `20660-script-loading-time` --- ### 📝 Commits (1) - [`54bc239`](https://github.com/netbox-community/netbox/commit/54bc23939b894936f1ecee4c65211ee7faab5158) Fixes #20660: Optimize loading of custom script modules from remote storage ### 📊 Changes **2 files changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/models/mixins.py` (+1 -2) 📝 `netbox/extras/models/scripts.py` (+1 -1) </details> ### 📄 Description ### Fixes: #20660 - Tweak `exec_module()` to avoid forcing the creation of a new storage connection on each call - Convert `module_scripts` to a cached property, to avoid triggering a new fetch for each script within a module file Some quick testing using three modules comprising five total scripts shows total rendering time for the script list view reduced from ~4.15s to ~0.80s. There is still some linear increment per script module, as each file must be fetched from remote storage, but it should be greatly reduced. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:25:31 +01:00

adam closed this issue

2025-12-30 00:25:31 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#16050