starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 14:23:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20764] [MERGED] #20378 fix delete of DataSource #16043

New Issue
Closed
opened 2025-12-30 00:25:28 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:25:28 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20764
Author: @arthanson
Created: 11/7/2025
Status: ✅ Merged
Merged: 11/7/2025
Merged by: @bctiemann

Base: main ← Head: 20378-del-script

📝 Commits (1)

📊 Changes

1 file changed (+0 additions, -4 deletions)

View changed files

📝 netbox/core/models/files.py (+0 -4)

📄 Description

Fixes: #20378

core:managedfile is not a valid url so this function is not getting hit regardless. The error handler already handles objects without this method gracefully. and the correct error message is returned

Monosnap ads | NetBox 2025-11-06 16-00-11

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20764 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 11/7/2025 **Status:** ✅ Merged **Merged:** 11/7/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `main` ← **Head:** `20378-del-script` --- ### 📝 Commits (1) - [`588c069`](https://github.com/netbox-community/netbox/commit/588c069ff14fb1bac9eb98aa4b3fab305790265a) #20378 fix delete of DataSource ### 📊 Changes **1 file changed** (+0 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `netbox/core/models/files.py` (+0 -4) </details> ### 📄 Description ### Fixes: #20378 `core:managedfile` is not a valid url so this function is not getting hit regardless. The error handler already handles objects without this method gracefully. and the correct error message is returned <img width="741" height="822" alt="Monosnap ads | NetBox 2025-11-06 16-00-11" src="https://github.com/user-attachments/assets/e21850e6-7e08-4294-8dba-2e9bc598d5a2" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:25:28 +01:00
adam closed this issue 2025-12-30 00:25:28 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#16043
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?