[PR #20739] [MERGED] 20738 update vc_position in delete not signal handler #16035

New Issue

adam · 2025-12-30T00:25:25+01:00

adam commented

2025-12-30 00:25:25 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20739
Author: @arthanson
Created: 11/3/2025
Status: ✅ Merged
Merged: 11/6/2025
Merged by: @bctiemann

Base: main ← Head: 20738-vc-delete

📝 Commits (3)

264b40a 20738 update vc_position in delete not signal handler
20af97c 20738 update vc_position in delete not signal handler
8522c03 20738 add tests

📊 Changes

3 files changed (+97 additions, -14 deletions)

View changed files

📝 netbox/dcim/models/devices.py (+7 -1)
📝 netbox/dcim/signals.py (+1 -13)
📝 netbox/dcim/tests/test_models.py (+89 -0)

📄 Description

Fixes: #20738

vc_position and vc_priority were getting set to None when a virtual chassis was deleted, however the signal handler is getting run after the set_null is already getting run meaning no devices were found in the loop and so they were never getting cleared. Moved this to this functionality to the delete method.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20739 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 11/3/2025 **Status:** ✅ Merged **Merged:** 11/6/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `main` ← **Head:** `20738-vc-delete` --- ### 📝 Commits (3) - [`264b40a`](https://github.com/netbox-community/netbox/commit/264b40a269a6d63d32c7ac2920055538290b608c) 20738 update vc_position in delete not signal handler - [`20af97c`](https://github.com/netbox-community/netbox/commit/20af97ce24976a88a1f2454b9a49a2f5bd4585ec) 20738 update vc_position in delete not signal handler - [`8522c03`](https://github.com/netbox-community/netbox/commit/8522c03b719c07f149bd41fc79a688adef996247) 20738 add tests ### 📊 Changes **3 files changed** (+97 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/models/devices.py` (+7 -1) 📝 `netbox/dcim/signals.py` (+1 -13) 📝 `netbox/dcim/tests/test_models.py` (+89 -0) </details> ### 📄 Description ### Fixes: #20738 vc_position and vc_priority were getting set to None when a virtual chassis was deleted, however the signal handler is getting run after the set_null is already getting run meaning no devices were found in the loop and so they were never getting cleared. Moved this to this functionality to the delete method. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:25:25 +01:00

adam closed this issue

2025-12-30 00:25:25 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#16035