starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20714] [MERGED] Fixes #20713: Record pre-change snapshots on VC members being added/removed #16022

New Issue
Closed
opened 2025-12-30 00:25:22 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:25:22 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20714
Author: @jeremystretch
Created: 10/29/2025
Status: ✅ Merged
Merged: 10/30/2025
Merged by: @jnovinger

Base: main ← Head: 20713-vc-member-snapshots

📝 Commits (1)

  • b9a9336 Fixes #20713: Record pre-change snapshots on VC members being added/removed

📊 Changes

2 files changed (+12 additions, -18 deletions)

View changed files

📝 netbox/dcim/forms/object_create.py (+1 -0)
📝 netbox/dcim/views.py (+11 -18)

📄 Description

Fixes: #20713

  • Call snapshot() on member devices before assigning/removing the virtual chassis
  • Also call snapshot() on the virtual chassis under VirtualChassisEditView
  • Clean up excessive empty lines

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20714 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 10/29/2025 **Status:** ✅ Merged **Merged:** 10/30/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `main` ← **Head:** `20713-vc-member-snapshots` --- ### 📝 Commits (1) - [`b9a9336`](https://github.com/netbox-community/netbox/commit/b9a933639875db22a8f56ab9fc8b2bee472c67d6) Fixes #20713: Record pre-change snapshots on VC members being added/removed ### 📊 Changes **2 files changed** (+12 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms/object_create.py` (+1 -0) 📝 `netbox/dcim/views.py` (+11 -18) </details> ### 📄 Description ### Fixes: #20713 - Call `snapshot()` on member devices before assigning/removing the virtual chassis - Also call `snapshot()` on the virtual chassis under VirtualChassisEditView - Clean up excessive empty lines --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:25:22 +01:00
adam closed this issue 2025-12-30 00:25:22 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#16022
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?