starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20706] [MERGED] Closes: #17936 - GFK serializer field #16019

New Issue
Closed
opened 2025-12-30 00:25:21 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:25:21 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20706
Author: @bctiemann
Created: 10/28/2025
Status: ✅ Merged
Merged: 11/4/2025
Merged by: @jeremystretch

Base: feature ← Head: 17936-gfk-serializer-field

📝 Commits (5)

  • 182a927 Establish GFKSerializerField and replace get_* methods in circuits.py
  • 9e8fa6e Set read_only=True
  • e08810a Merge branch 'feature' into 17936-gfk-serializer-field
  • 7b5349e Apply GFKSerializerField to all matching SerializerMethodFields
  • 01362b8 Use GFKSerializerField for ObjectChangeSerializer.changed_object and EventRuleSerializer.action_object

📊 Changes

22 files changed (+119 additions, -318 deletions)

View changed files

📝 contrib/openapi.json (+52 -49)
📝 netbox/circuits/api/serializers_/circuits.py (+4 -29)
📝 netbox/core/api/serializers_/change_logging.py (+7 -22)
📝 netbox/dcim/api/serializers_/cables.py (+2 -9)
📝 netbox/dcim/api/serializers_/device_components.py (+2 -11)
📝 netbox/dcim/api/serializers_/devices.py (+2 -10)
📝 netbox/dcim/api/serializers_/devicetype_components.py (+2 -11)
📝 netbox/extras/api/serializers_/attachments.py (+2 -9)
📝 netbox/extras/api/serializers_/bookmarks.py (+2 -11)
📝 netbox/extras/api/serializers_/events.py (+2 -18)
📝 netbox/extras/api/serializers_/journaling.py (+2 -9)
📝 netbox/extras/api/serializers_/notifications.py (+3 -18)
📝 netbox/ipam/api/serializers_/fhrpgroups.py (+2 -13)
📝 netbox/ipam/api/serializers_/ip.py (+3 -20)
📝 netbox/ipam/api/serializers_/services.py (+2 -12)
📝 netbox/ipam/api/serializers_/vlans.py (+2 -11)
➕ netbox/netbox/api/gfk_fields.py (+18 -0)
📝 netbox/tenancy/api/serializers_/contacts.py (+2 -10)
📝 netbox/virtualization/api/serializers_/clusters.py (+2 -11)
📝 netbox/vpn/api/serializers_/l2vpn.py (+2 -10)

...and 2 more files

📄 Description

Closes: #17936

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20706 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 10/28/2025 **Status:** ✅ Merged **Merged:** 11/4/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `17936-gfk-serializer-field` --- ### 📝 Commits (5) - [`182a927`](https://github.com/netbox-community/netbox/commit/182a927d34716e60acb1a68eb6236811a6251fa2) Establish GFKSerializerField and replace get_* methods in circuits.py - [`9e8fa6e`](https://github.com/netbox-community/netbox/commit/9e8fa6e61fb771a2e8ff25e36d82f480f5d4d11a) Set read_only=True - [`e08810a`](https://github.com/netbox-community/netbox/commit/e08810a4c53f8b12c7f743d660aff0d75236b5b5) Merge branch 'feature' into 17936-gfk-serializer-field - [`7b5349e`](https://github.com/netbox-community/netbox/commit/7b5349e1dc4c17a05600629b1be0039e0878caa0) Apply GFKSerializerField to all matching SerializerMethodFields - [`01362b8`](https://github.com/netbox-community/netbox/commit/01362b8482a505d1788250f7a1ade0b3deee4c94) Use GFKSerializerField for ObjectChangeSerializer.changed_object and EventRuleSerializer.action_object ### 📊 Changes **22 files changed** (+119 additions, -318 deletions) <details> <summary>View changed files</summary> 📝 `contrib/openapi.json` (+52 -49) 📝 `netbox/circuits/api/serializers_/circuits.py` (+4 -29) 📝 `netbox/core/api/serializers_/change_logging.py` (+7 -22) 📝 `netbox/dcim/api/serializers_/cables.py` (+2 -9) 📝 `netbox/dcim/api/serializers_/device_components.py` (+2 -11) 📝 `netbox/dcim/api/serializers_/devices.py` (+2 -10) 📝 `netbox/dcim/api/serializers_/devicetype_components.py` (+2 -11) 📝 `netbox/extras/api/serializers_/attachments.py` (+2 -9) 📝 `netbox/extras/api/serializers_/bookmarks.py` (+2 -11) 📝 `netbox/extras/api/serializers_/events.py` (+2 -18) 📝 `netbox/extras/api/serializers_/journaling.py` (+2 -9) 📝 `netbox/extras/api/serializers_/notifications.py` (+3 -18) 📝 `netbox/ipam/api/serializers_/fhrpgroups.py` (+2 -13) 📝 `netbox/ipam/api/serializers_/ip.py` (+3 -20) 📝 `netbox/ipam/api/serializers_/services.py` (+2 -12) 📝 `netbox/ipam/api/serializers_/vlans.py` (+2 -11) ➕ `netbox/netbox/api/gfk_fields.py` (+18 -0) 📝 `netbox/tenancy/api/serializers_/contacts.py` (+2 -10) 📝 `netbox/virtualization/api/serializers_/clusters.py` (+2 -11) 📝 `netbox/vpn/api/serializers_/l2vpn.py` (+2 -10) _...and 2 more files_ </details> ### 📄 Description ## Closes: #17936 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:25:21 +01:00
adam closed this issue 2025-12-30 00:25:21 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#16019
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?