starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20657] [MERGED] Closes #20459 : clean is_oob and is_primary on bulk_import #15998

New Issue
Closed
opened 2025-12-30 00:25:14 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:25:14 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20657
Author: @pl0xym0r
Created: 10/22/2025
Status: ✅ Merged
Merged: 10/25/2025
Merged by: @jnovinger

Base: main ← Head: 20459_bulk_import_ip_issue_oob

📝 Commits (1)

  • 7a622e9 Closes #20459 : clean is_oob and is_primary on bulk_import

📊 Changes

1 file changed (+19 additions, -5 deletions)

View changed files

📝 netbox/ipam/forms/bulk_import.py (+19 -5)

📄 Description

Closes: #20459

I used the same logic as https://github.com/netbox-community/netbox/blob/main/netbox/dcim/forms/bulk_import.py#L768 in order to clean the parameters coming from a CSV.
Then, once data is cleaned, apply if parameter are true or false on assigned_objects.
Test are ok

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20657 **Author:** [@pl0xym0r](https://github.com/pl0xym0r) **Created:** 10/22/2025 **Status:** ✅ Merged **Merged:** 10/25/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `main` ← **Head:** `20459_bulk_import_ip_issue_oob` --- ### 📝 Commits (1) - [`7a622e9`](https://github.com/netbox-community/netbox/commit/7a622e9b09a60f254a28cb4738573cbecd5ccc79) Closes #20459 : clean is_oob and is_primary on bulk_import ### 📊 Changes **1 file changed** (+19 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/forms/bulk_import.py` (+19 -5) </details> ### 📄 Description Closes: #20459 I used the same logic as https://github.com/netbox-community/netbox/blob/main/netbox/dcim/forms/bulk_import.py#L768 in order to clean the parameters coming from a CSV. Then, once data is cleaned, apply if parameter are true or false on assigned_objects. Test are ok --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:25:14 +01:00
adam closed this issue 2025-12-30 00:25:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15998
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?