starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20651] [MERGED] Fixes #19872: Display script form validation errors #15997

New Issue
Closed
opened 2025-12-30 00:25:14 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:25:14 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20651
Author: @jnovinger
Created: 10/21/2025
Status: ✅ Merged
Merged: 10/23/2025
Merged by: @bctiemann

Base: main ← Head: 19872-script-validation-errors

📝 Commits (2)

  • 2fdd46f Fixes #19872: Display form validation errors for script execution
  • 5fbae84 Only show non-rendered field errors in toast

📊 Changes

2 files changed (+79 additions, -0 deletions)

View changed files

📝 netbox/extras/tests/test_views.py (+70 -0)
📝 netbox/extras/views.py (+9 -0)

📄 Description

Fixes: #19872

When script form validation fails (e.g., required fields excluded from fieldsets), display error messages via Django's message framework instead of failing silently.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20651 **Author:** [@jnovinger](https://github.com/jnovinger) **Created:** 10/21/2025 **Status:** ✅ Merged **Merged:** 10/23/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `main` ← **Head:** `19872-script-validation-errors` --- ### 📝 Commits (2) - [`2fdd46f`](https://github.com/netbox-community/netbox/commit/2fdd46f64cdd7791169990918d662ec9a77cddb3) Fixes #19872: Display form validation errors for script execution - [`5fbae84`](https://github.com/netbox-community/netbox/commit/5fbae8407e408da2e7ed7074e87b0424e4969284) Only show non-rendered field errors in toast ### 📊 Changes **2 files changed** (+79 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/tests/test_views.py` (+70 -0) 📝 `netbox/extras/views.py` (+9 -0) </details> ### 📄 Description ### Fixes: #19872 When script form validation fails (e.g., required fields excluded from fieldsets), display error messages via Django's message framework instead of failing silently. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:25:14 +01:00
adam closed this issue 2025-12-30 00:25:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15997
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?