[PR #20642] [MERGED] Fixes #20641: Handle viewsets with queryset=None in get_view_name() #15995

New Issue

adam · 2025-12-30T00:25:13+01:00

adam commented

2025-12-30 00:25:13 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20642
Author: @jnovinger
Created: 10/21/2025
Status: ✅ Merged
Merged: 10/23/2025
Merged by: @arthanson

Base: main ← Head: 20641-fix-objectchange-browsable-api

📝 Commits (1)

977b10f Fixes #20641: Handle viewsets with queryset=None in get_view_name()

📊 Changes

2 files changed (+19 additions, -2 deletions)

View changed files

📝 netbox/utilities/api.py (+1 -1)
📝 netbox/utilities/tests/test_api.py (+18 -1)

📄 Description

Fixes: #20641

The get_view_name() utility function crashed with AttributeError when called on viewsets that override get_queryset() without setting a class-level queryset attribute (e.g., ObjectChangeViewSet).

This pattern became necessary in #20089 to force re-evaluation of valid_models() on each request, ensuring ObjectChange querysets reflect current ContentType state.

Added None check to fall back to DRF's default view naming when no class-level queryset exists.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20642 **Author:** [@jnovinger](https://github.com/jnovinger) **Created:** 10/21/2025 **Status:** ✅ Merged **Merged:** 10/23/2025 **Merged by:** [@arthanson](https://github.com/arthanson) **Base:** `main` ← **Head:** `20641-fix-objectchange-browsable-api` --- ### 📝 Commits (1) - [`977b10f`](https://github.com/netbox-community/netbox/commit/977b10f71fb2c603370d2e5accb2c9f846e48c96) Fixes #20641: Handle viewsets with queryset=None in get_view_name() ### 📊 Changes **2 files changed** (+19 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/utilities/api.py` (+1 -1) 📝 `netbox/utilities/tests/test_api.py` (+18 -1) </details> ### 📄 Description Fixes: #20641 The get_view_name() utility function crashed with AttributeError when called on viewsets that override get_queryset() without setting a class-level queryset attribute (e.g., ObjectChangeViewSet). This pattern became necessary in #20089 to force re-evaluation of valid_models() on each request, ensuring ObjectChange querysets reflect current ContentType state. Added None check to fall back to DRF's default view naming when no class-level queryset exists. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:25:13 +01:00

adam closed this issue

2025-12-30 00:25:13 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15995