[PR #20538] [MERGED] Fixes #20466: Correct handling of assigned filter logic #15959

New Issue

adam · 2025-12-30T00:25:01+01:00

adam commented

2025-12-30 00:25:01 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20538
Author: @pheus
Created: 10/9/2025
Status: ✅ Merged
Merged: 10/19/2025
Merged by: @jnovinger

Base: main ← Head: 20466-fix-assigned-graphql-ipaddressfilter

📝 Commits (1)

5bdc4fa fix(graphql): Correct handling of assigned filter logic

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/ipam/graphql/filters.py (+1 -1)

📄 Description

Fixes: #20466

Summary

Correct the custom GraphQL filter IPAddressFilter.assigned to use the nested relation prefix supplied by Strawberry‑Django.
Prior behavior built a non‑prefixed Q, so when used under another filter (e.g., Device → primary_ip4), Django attempted to resolve assigned_object_id on the outer model and failed.
New behavior dynamically qualifies the lookup with prefix, ensuring the condition targets the nested IPAddress.

Change

@strawberry_django.filter_field()
def assigned(self, value: bool, prefix) -> Q:
-    return Q(assigned_object_id__isnull=(not value))
+    return Q(**{f"{prefix}assigned_object_id__isnull": not value})

Why

Nested GraphQL queries like the example below errored due to the missing prefix; with this change they work as intended.

query {
  device_list(filters: { primary_ip4: { assigned: true } }) {
    id
    name
    primary_ip4 { address }
  }
}

Follow‑up

Propose a small audit for other @strawberry_django.filter_field methods that construct raw Q(...) lookups without applying prefix.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20538 **Author:** [@pheus](https://github.com/pheus) **Created:** 10/9/2025 **Status:** ✅ Merged **Merged:** 10/19/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `main` ← **Head:** `20466-fix-assigned-graphql-ipaddressfilter` --- ### 📝 Commits (1) - [`5bdc4fa`](https://github.com/netbox-community/netbox/commit/5bdc4fa87bf9cc2d664300f483e4a3d16f5691e1) fix(graphql): Correct handling of `assigned` filter logic ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/graphql/filters.py` (+1 -1) </details> ### 📄 Description ### Fixes: #20466  #### Summary - Correct the custom GraphQL filter `IPAddressFilter.assigned` to use the nested relation `prefix` supplied by Strawberry‑Django. - Prior behavior built a non‑prefixed `Q`, so when used under another filter (e.g., `Device → primary_ip4`), Django attempted to resolve `assigned_object_id` on the outer model and failed. - New behavior dynamically qualifies the lookup with `prefix`, ensuring the condition targets the nested `IPAddress`. #### Change ```diff @strawberry_django.filter_field() def assigned(self, value: bool, prefix) -> Q: - return Q(assigned_object_id__isnull=(not value)) + return Q(**{f"{prefix}assigned_object_id__isnull": not value}) ``` #### Why Nested GraphQL queries like the example below errored due to the missing prefix; with this change they work as intended. ```graphql query { device_list(filters: { primary_ip4: { assigned: true } }) { id name primary_ip4 { address } } } ``` #### Follow‑up - Propose a small audit for other `@strawberry_django.filter_field` methods that construct raw `Q(...)` lookups without applying `prefix`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:25:01 +01:00

adam closed this issue

2025-12-30 00:25:01 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15959

[PR #20538] [MERGED] Fixes #20466: Correct handling of assigned filter logic #15959