starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20444] [MERGED] Fixes #20425: Fix Markdown preview functionality within "quick add" modal #15922

New Issue
Closed
opened 2025-12-30 00:24:49 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:24:49 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20444
Author: @jeremystretch
Created: 9/29/2025
Status: ✅ Merged
Merged: 9/30/2025
Merged by: @jeremystretch

Base: main ← Head: 20245-quick-add-markdown-preview

📝 Commits (1)

  • b37ce87 Fixes #20245: Fix Markdown preview functionality within "quick add" modal

📊 Changes

4 files changed (+8 additions, -18 deletions)

View changed files

📝 netbox/netbox/views/generic/object_views.py (+2 -1)
📝 netbox/project-static/dist/netbox.js (+3 -3)
📝 netbox/project-static/dist/netbox.js.map (+3 -3)
📝 netbox/project-static/src/buttons/markdownPreview.ts (+0 -11)

📄 Description

Fixes: #20425

  • Add a prefix to fields in the "quick add" form to ensure each field on the page has a unique ID
  • Remove the manual field height assignment Typescript, which sets height: 0px on the modal field

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20444 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 9/29/2025 **Status:** ✅ Merged **Merged:** 9/30/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `20245-quick-add-markdown-preview` --- ### 📝 Commits (1) - [`b37ce87`](https://github.com/netbox-community/netbox/commit/b37ce8744acca8a5c7780a0b5058672cdd6c28d6) Fixes #20245: Fix Markdown preview functionality within "quick add" modal ### 📊 Changes **4 files changed** (+8 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/views/generic/object_views.py` (+2 -1) 📝 `netbox/project-static/dist/netbox.js` (+3 -3) 📝 `netbox/project-static/dist/netbox.js.map` (+3 -3) 📝 `netbox/project-static/src/buttons/markdownPreview.ts` (+0 -11) </details> ### 📄 Description ### Fixes: #20425 - Add a prefix to fields in the "quick add" form to ensure each field on the page has a unique ID - Remove the manual field height assignment Typescript, which sets `height: 0px` on the modal field --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:24:49 +01:00
adam closed this issue 2025-12-30 00:24:49 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15922
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?