[PR #20401] [MERGED] Fixes #20398: Rely on browser-native form field validation #15916

New Issue

adam · 2025-12-30T00:24:47+01:00

adam commented

2025-12-30 00:24:47 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20401
Author: @jeremystretch
Created: 9/19/2025
Status: ✅ Merged
Merged: 9/19/2025
Merged by: @jnovinger

Base: main ← Head: 20398-foem-field-validation

📝 Commits (1)

1af16fa Fixes #20398: Rely on browser-native form field validation

📊 Changes

5 files changed (+12 additions, -47 deletions)

View changed files

📝 netbox/project-static/dist/netbox.js (+4 -4)
📝 netbox/project-static/dist/netbox.js.map (+3 -3)
📝 netbox/project-static/src/forms/elements.ts (+5 -35)
📝 netbox/templates/dcim/htmx/cable_edit.html (+0 -1)
📝 netbox/utilities/templates/form_helpers/render_field.html (+0 -4)

📄 Description

Fixes: #20398

Remove the TypeScript which applies the is-invalid CSS class to form fields with invalid values on form submit
Remove the call to event.preventDefault() to allow the native browser validation to take over
Remove the now-obsolete generic "This field is required" warning from the form template

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20401 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 9/19/2025 **Status:** ✅ Merged **Merged:** 9/19/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `main` ← **Head:** `20398-foem-field-validation` --- ### 📝 Commits (1) - [`1af16fa`](https://github.com/netbox-community/netbox/commit/1af16fab46735861b3ada222b3dd430d6abab09d) Fixes #20398: Rely on browser-native form field validation ### 📊 Changes **5 files changed** (+12 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `netbox/project-static/dist/netbox.js` (+4 -4) 📝 `netbox/project-static/dist/netbox.js.map` (+3 -3) 📝 `netbox/project-static/src/forms/elements.ts` (+5 -35) 📝 `netbox/templates/dcim/htmx/cable_edit.html` (+0 -1) 📝 `netbox/utilities/templates/form_helpers/render_field.html` (+0 -4) </details> ### 📄 Description ### Fixes: #20398 - Remove the TypeScript which applies the `is-invalid` CSS class to form fields with invalid values on form submit - Remove the call to `event.preventDefault()` to allow the native browser validation to take over - Remove the now-obsolete generic "This field is required" warning from the form template --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:24:47 +01:00

adam closed this issue

2025-12-30 00:24:47 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15916