starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20387] [MERGED] Fixes #20375: Preserve filter params when performing bulk operations #15914

New Issue
Closed
opened 2025-12-30 00:24:46 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:24:46 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20387
Author: @jeremystretch
Created: 9/18/2025
Status: ✅ Merged
Merged: 9/18/2025
Merged by: @jnovinger

Base: main ← Head: 20375-bulk-edit-filters

📝 Commits (2)

  • 9e24f13 Fixes #20375: Preserve filter params when performing bulk operations
  • a1e960a Remove errant template tag

📊 Changes

8 files changed (+25 additions, -16 deletions)

View changed files

📝 netbox/netbox/object_actions.py (+9 -0)
📝 netbox/templates/core/buttons/bulk_sync.html (+1 -1)
📝 netbox/templates/dcim/buttons/bulk_add_components.html (+9 -9)
📝 netbox/templates/dcim/buttons/bulk_disconnect.html (+1 -1)
📝 netbox/templates/virtualization/buttons/bulk_add_components.html (+2 -2)
📝 netbox/utilities/templates/buttons/bulk_delete.html (+1 -1)
📝 netbox/utilities/templates/buttons/bulk_edit.html (+1 -1)
📝 netbox/utilities/templates/buttons/bulk_rename.html (+1 -1)

📄 Description

Fixes: #20375

  • Add the get_url_params() method on ObjectAction to return a QueryDict of URL query parameters
  • Provide this QueryDict as url_params in the button template context
  • Update all button templates to reference url_params

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20387 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 9/18/2025 **Status:** ✅ Merged **Merged:** 9/18/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `main` ← **Head:** `20375-bulk-edit-filters` --- ### 📝 Commits (2) - [`9e24f13`](https://github.com/netbox-community/netbox/commit/9e24f139f53073c3fc45c313acb1707f2966d8ef) Fixes #20375: Preserve filter params when performing bulk operations - [`a1e960a`](https://github.com/netbox-community/netbox/commit/a1e960afcdf6023b034bab9952569d8cedd4179e) Remove errant template tag ### 📊 Changes **8 files changed** (+25 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/object_actions.py` (+9 -0) 📝 `netbox/templates/core/buttons/bulk_sync.html` (+1 -1) 📝 `netbox/templates/dcim/buttons/bulk_add_components.html` (+9 -9) 📝 `netbox/templates/dcim/buttons/bulk_disconnect.html` (+1 -1) 📝 `netbox/templates/virtualization/buttons/bulk_add_components.html` (+2 -2) 📝 `netbox/utilities/templates/buttons/bulk_delete.html` (+1 -1) 📝 `netbox/utilities/templates/buttons/bulk_edit.html` (+1 -1) 📝 `netbox/utilities/templates/buttons/bulk_rename.html` (+1 -1) </details> ### 📄 Description ### Fixes: #20375 - Add the `get_url_params()` method on ObjectAction to return a QueryDict of URL query parameters - Provide this QueryDict as `url_params` in the button template context - Update all button templates to reference `url_params` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:24:46 +01:00
adam closed this issue 2025-12-30 00:24:46 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15914
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?