starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20359] [MERGED] Fixes #20298: Add placeholder for failed image thumbnail generation #15907

New Issue
Closed
opened 2025-12-30 00:24:44 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:24:44 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20359
Author: @jnovinger
Created: 9/15/2025
Status: ✅ Merged
Merged: 9/16/2025
Merged by: @arthanson

Base: main ← Head: 20298-placeholder-image

📝 Commits (1)

  • 6d078f8 Fixes #20298: Add placeholder for failed image thumbnail generation

📊 Changes

1 file changed (+10 additions, -0 deletions)

View changed files

📝 netbox/templates/extras/object_imageattachments.html (+10 -0)

📄 Description

Fixes: #20298

When Redis cache lacks disk persistence sorl-thumbnail fails to generate thumbnails, leaving only bare filename text visible. This adds an {% empty %} fallback block to the thumbnail template that displays a placeholder with a broken image icon and user instructions when thumbnail generation fails.

The placeholder maintains the expected 200x200px dimensions and provides:

  • Broken image icon (mdi-image-broken-variant)
  • Error message explaining the issue
  • Clickable link to view the original image
  • High contrast text (text-dark) for readability on light background

This can be tested by changing the permission on the thumbnail cache directory before adding a thumbnail, via chmod 444 netbox/media/cache. Just remember to change the permission back after testing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20359 **Author:** [@jnovinger](https://github.com/jnovinger) **Created:** 9/15/2025 **Status:** ✅ Merged **Merged:** 9/16/2025 **Merged by:** [@arthanson](https://github.com/arthanson) **Base:** `main` ← **Head:** `20298-placeholder-image` --- ### 📝 Commits (1) - [`6d078f8`](https://github.com/netbox-community/netbox/commit/6d078f8768adba4df04c16499509ef8625716048) Fixes #20298: Add placeholder for failed image thumbnail generation ### 📊 Changes **1 file changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/templates/extras/object_imageattachments.html` (+10 -0) </details> ### 📄 Description ### Fixes: #20298 When Redis cache lacks disk persistence `sorl-thumbnail` fails to generate thumbnails, leaving only bare filename text visible. This adds an `{% empty %}` fallback block to the thumbnail template that displays a placeholder with a broken image icon and user instructions when thumbnail generation fails. The placeholder maintains the expected 200x200px dimensions and provides: - Broken image icon (`mdi-image-broken-variant`) - Error message explaining the issue - Clickable link to view the original image - High contrast text (`text-dark`) for readability on light background This can be tested by changing the permission on the thumbnail cache directory before adding a thumbnail, via `chmod 444 netbox/media/cache`. Just remember to change the permission back after testing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:24:44 +01:00
adam closed this issue 2025-12-30 00:24:44 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15907
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?