starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20354] [MERGED] Closes #19262: Remove FHRP IP prefix constraint #15906

New Issue
Closed
opened 2025-12-30 00:24:43 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:24:43 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20354
Author: @pheus
Created: 9/14/2025
Status: ✅ Merged
Merged: 9/15/2025
Merged by: @jeremystretch

Base: main ← Head: 19262-lift-fhrp-ip-prefix-constraint

📝 Commits (1)

  • 022d988 fix(ipam): Remove FHRP IP prefix constraint

📊 Changes

2 files changed (+1 additions, -7 deletions)

View changed files

📝 netbox/ipam/filtersets.py (+1 -0)
📝 netbox/ipam/forms/model_forms.py (+0 -7)

📄 Description

Fixes: #19262

  • Lift the “same prefix” requirement when assigning FHRP groups to interfaces.
  • Remove FHRPGroupAssignmentForm.__init__ filtering; show all groups regardless of VIP subnet.
  • Add group_id to the q filter for matching by group ID (per maintainer feedback).

Reason: NAT/shared VIP subnets mean interface IP and VIP prefixes can differ; type‑ahead search keeps selection manageable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20354 **Author:** [@pheus](https://github.com/pheus) **Created:** 9/14/2025 **Status:** ✅ Merged **Merged:** 9/15/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `19262-lift-fhrp-ip-prefix-constraint` --- ### 📝 Commits (1) - [`022d988`](https://github.com/netbox-community/netbox/commit/022d988ad98577aff367b4d5dbec45eb56e96a8c) fix(ipam): Remove FHRP IP prefix constraint ### 📊 Changes **2 files changed** (+1 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/filtersets.py` (+1 -0) 📝 `netbox/ipam/forms/model_forms.py` (+0 -7) </details> ### 📄 Description ### Fixes: #19262 - Lift the “same prefix” requirement when assigning FHRP groups to interfaces. - Remove `FHRPGroupAssignmentForm.__init__` filtering; show all groups regardless of VIP subnet. - Add `group_id` to the `q` filter for matching by group ID (per maintainer feedback). **Reason:** NAT/shared VIP subnets mean interface IP and VIP prefixes can differ; type‑ahead search keeps selection manageable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:24:43 +01:00
adam closed this issue 2025-12-30 00:24:43 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15906
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?