starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20325] [MERGED] Closes #20088: Remove model from webhook context (replaced by object_type) #15894

New Issue
Closed
opened 2025-12-30 00:24:39 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:24:39 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20325
Author: @jeremystretch
Created: 9/11/2025
Status: ✅ Merged
Merged: 9/12/2025
Merged by: @arthanson

Base: feature ← Head: 20088-remove-model-from-webhook-context

📝 Commits (2)

  • c4587f9 Closes #20088: Remove 'model' from webhook context (replaced by object_type)
  • 71f3cc6 Fix test & logging

📊 Changes

2 files changed (+2 additions, -3 deletions)

View changed files

📝 netbox/extras/tests/test_event_rules.py (+1 -1)
📝 netbox/extras/webhooks.py (+1 -2)

📄 Description

Closes: #20088

The fully-qualified key object_type was added in NetBox v4.4 under FR #20029 to supersede model, which is prone to naming collisions.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20325 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 9/11/2025 **Status:** ✅ Merged **Merged:** 9/12/2025 **Merged by:** [@arthanson](https://github.com/arthanson) **Base:** `feature` ← **Head:** `20088-remove-model-from-webhook-context` --- ### 📝 Commits (2) - [`c4587f9`](https://github.com/netbox-community/netbox/commit/c4587f9748291bdf497aab441f8fa301555a81c3) Closes #20088: Remove 'model' from webhook context (replaced by object_type) - [`71f3cc6`](https://github.com/netbox-community/netbox/commit/71f3cc6e70a03162210b82eb09f19a8c0b2b1dc3) Fix test & logging ### 📊 Changes **2 files changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/tests/test_event_rules.py` (+1 -1) 📝 `netbox/extras/webhooks.py` (+1 -2) </details> ### 📄 Description ### Closes: #20088 The fully-qualified key `object_type` was added in NetBox v4.4 under FR #20029 to supersede `model`, which is prone to naming collisions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:24:39 +01:00
adam closed this issue 2025-12-30 00:24:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15894
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?