[PR #20289] [MERGED] Fixes 19729: GraphQL filter interfaces by kind #15876

New Issue

adam · 2025-12-30T00:24:33+01:00

adam commented

2025-12-30 00:24:33 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20289
Author: @llamafilm
Created: 9/6/2025
Status: ✅ Merged
Merged: 9/8/2025
Merged by: @jnovinger

Base: main ← Head: 19729-kind

📝 Commits (3)

4886a10 add kind enum filter
d52fb35 add connected bool filter
2861435 Merge branch 'main' into 19729-kind

📊 Changes

2 files changed (+26 additions, -0 deletions)

View changed files

📝 netbox/dcim/graphql/enums.py (+2 -0)
📝 netbox/dcim/graphql/filters.py (+24 -0)

📄 Description

Fixes: #19729

Define a custom enum filter method for kind so it works as it did prior to v4.3.

Also added connected filter as suggested in the comments. I implemented this as a bool type, rather than FilterLookup[bool] because the other complex lookup types don't make sense with this queryset definition.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20289 **Author:** [@llamafilm](https://github.com/llamafilm) **Created:** 9/6/2025 **Status:** ✅ Merged **Merged:** 9/8/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `main` ← **Head:** `19729-kind` --- ### 📝 Commits (3) - [`4886a10`](https://github.com/netbox-community/netbox/commit/4886a1057c3e3fbc5bac1979acd99c0337a0f05b) add kind enum filter - [`d52fb35`](https://github.com/netbox-community/netbox/commit/d52fb35400526e613a65873e103828cb8597abc6) add connected bool filter - [`2861435`](https://github.com/netbox-community/netbox/commit/2861435c43ab3150b73a6b3161b42d77203bff4a) Merge branch 'main' into 19729-kind ### 📊 Changes **2 files changed** (+26 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/graphql/enums.py` (+2 -0) 📝 `netbox/dcim/graphql/filters.py` (+24 -0) </details> ### 📄 Description ### Fixes: #19729 Define a custom enum filter method for `kind` so it works as it did prior to v4.3. Also added `connected` filter as suggested in the comments. I implemented this as a `bool` type, rather than `FilterLookup[bool]` because the other complex lookup types don't make sense with this queryset definition. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:24:33 +01:00

adam closed this issue

2025-12-30 00:24:33 +01:00

Sign in to join this conversation.

Branches Tags

main

21102-fix-graphiql-explorer

update-changelog-comments-docs

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15876