[PR #20280] [MERGED] Fixes #20264: Update plugin title rendering with default icon #15875

Closed
opened 2025-12-30 00:24:32 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20280
Author: @pheus
Created: 9/5/2025
Status: Merged
Merged: 9/8/2025
Merged by: @bctiemann

Base: mainHead: 20264-fix-plugin-icon-display-in-plugin-table


📝 Commits (1)

  • b24f8fb feat(core): Update plugin title rendering with default icon

📊 Changes

3 files changed (+13 additions, -16 deletions)

View changed files

📝 netbox/core/tables/plugins.py (+2 -16)
📝 netbox/core/tables/template_code.py (+10 -0)
netbox/project-static/img/plugin-default.svg (+1 -0)

📄 Description

Fixes: #20264

Summary

  • Replace inline plugin title markup with a reusable template in template_code.py.
  • Add a default core SVG icon used when no plugin icon is provided.
  • Keep title_long as a TemplateColumn using the template; remove redundant render_title_long().
  • Correct order_by from nametitle_long.

Impact

  • UI-only; no API/DB changes.
  • Deduplicates logic and ensures consistent icon rendering.
  • Catalog/author-supplied icon_url still overrides the default.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20280 **Author:** [@pheus](https://github.com/pheus) **Created:** 9/5/2025 **Status:** ✅ Merged **Merged:** 9/8/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `main` ← **Head:** `20264-fix-plugin-icon-display-in-plugin-table` --- ### 📝 Commits (1) - [`b24f8fb`](https://github.com/netbox-community/netbox/commit/b24f8fb340ecb6974157e46dd039c1666fc669c0) feat(core): Update plugin title rendering with default icon ### 📊 Changes **3 files changed** (+13 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `netbox/core/tables/plugins.py` (+2 -16) 📝 `netbox/core/tables/template_code.py` (+10 -0) ➕ `netbox/project-static/img/plugin-default.svg` (+1 -0) </details> ### 📄 Description ### Fixes: #20264 <!-- Please include a summary of the proposed changes below. --> **Summary** - Replace inline plugin title markup with a reusable template in `template_code.py`. - Add a **default core SVG icon** used when no plugin icon is provided. - Keep `title_long` as a `TemplateColumn` using the template; remove redundant `render_title_long()`. - Correct `order_by` from `name` → `title_long`. **Impact** - UI-only; no API/DB changes. - Deduplicates logic and ensures consistent icon rendering. - Catalog/author-supplied `icon_url` still overrides the default. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:24:32 +01:00
adam closed this issue 2025-12-30 00:24:32 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15875