starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20276] [MERGED] Fixes #20221: JSON CustomField does not coerce {} to null #15869

New Issue
Closed
opened 2025-12-30 00:24:30 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:24:30 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20276
Author: @jnovinger
Created: 9/5/2025
Status: ✅ Merged
Merged: 9/5/2025
Merged by: @jeremystretch

Base: main ← Head: 20221-json-custom-field-cant-handle-empty-object-as-default

📝 Commits (1)

  • e864520 Fixes #20221: JSON CustomField does not coerce {} to null

📊 Changes

3 files changed (+58 additions, -2 deletions)

View changed files

📝 netbox/extras/models/customfields.py (+1 -1)
📝 netbox/extras/tests/test_customfields.py (+56 -0)
📝 netbox/utilities/templates/builtins/customfield_value.html (+1 -1)

📄 Description

Fixes: #20221

This fix actually fixes this for all valid JSON values that evaluate to False in Python when loaded and cast to bool:
bool(json.loads(<val>)).

  • {}
  • []
  • 0
  • False

This does not change the behavior of () or "" which are both explicitly cited as "empty" values on JSONField.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20276 **Author:** [@jnovinger](https://github.com/jnovinger) **Created:** 9/5/2025 **Status:** ✅ Merged **Merged:** 9/5/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `20221-json-custom-field-cant-handle-empty-object-as-default` --- ### 📝 Commits (1) - [`e864520`](https://github.com/netbox-community/netbox/commit/e864520821f5cbc41f8314178256ac6a793a7138) Fixes #20221: JSON CustomField does not coerce `{}` to null ### 📊 Changes **3 files changed** (+58 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/models/customfields.py` (+1 -1) 📝 `netbox/extras/tests/test_customfields.py` (+56 -0) 📝 `netbox/utilities/templates/builtins/customfield_value.html` (+1 -1) </details> ### 📄 Description ### Fixes: #20221 This fix actually fixes this for all valid JSON values that evaluate to `False` in Python when loaded and cast to bool: `bool(json.loads(<val>))`. - `{}` - `[]` - `0` - `False` This does not change the behavior of `()` or `""` which are both explicitly cited as "empty" values on `JSONField`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:24:30 +01:00
adam closed this issue 2025-12-30 00:24:30 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15869
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?