starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20257] [MERGED] Fixes #20238 - Fix Outside IP field in Tunnel Termination bulk import form #15863

New Issue
Closed
opened 2025-12-30 00:24:28 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:24:28 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20257
Author: @pheus
Created: 9/4/2025
Status: ✅ Merged
Merged: 9/4/2025
Merged by: @jeremystretch

Base: main ← Head: 20238-fix-outside-ip-for-tunnel-termination-bulk-import

📝 Commits (1)

  • 0024a3c fix(vpn): Update to_field_name in bulk import form

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/vpn/forms/bulk_import.py (+1 -1)

📄 Description

Fixes: #20238

Changes the to_field_name from name to address for the outside_ip selector in the VPN Tunnel Termination bulk import form. This aligns with how other IP references are resolved and fixes the import error:

outside_ip: "name" is an invalid accessor field name.

After this change, imports like the example below work as expected:

tunnel role outside_ip virtual_machine termination
tunnel peer 1.1.1.1/32 vm int0

This ensures proper mapping and validation of IP addresses during bulk import.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20257 **Author:** [@pheus](https://github.com/pheus) **Created:** 9/4/2025 **Status:** ✅ Merged **Merged:** 9/4/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `20238-fix-outside-ip-for-tunnel-termination-bulk-import` --- ### 📝 Commits (1) - [`0024a3c`](https://github.com/netbox-community/netbox/commit/0024a3c46c5a75a7e99c1a13c889a29e997086c6) fix(vpn): Update `to_field_name` in bulk import form ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/vpn/forms/bulk_import.py` (+1 -1) </details> ### 📄 Description ### Fixes: #20238 Changes the `to_field_name` from `name` to `address` for the `outside_ip` selector in the VPN **Tunnel Termination** bulk import form. This aligns with how other IP references are resolved and fixes the import error: > `outside_ip: "name" is an invalid accessor field name.` After this change, imports like the example below work as expected: ```text tunnel role outside_ip virtual_machine termination tunnel peer 1.1.1.1/32 vm int0 ``` This ensures proper mapping and validation of IP addresses during bulk import. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:24:28 +01:00
adam closed this issue 2025-12-30 00:24:28 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15863
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?