[PR #20177] [MERGED] Fixes #18916: Fix styling of dynamic dropdowns with invalid selection #15844

New Issue

adam · 2025-12-30T00:24:22+01:00

adam commented

2025-12-30 00:24:22 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20177
Author: @jeremystretch
Created: 8/25/2025
Status: ✅ Merged
Merged: 8/26/2025
Merged by: @bctiemann

Base: main ← Head: 18916-TomSelect-invalid-styling

📝 Commits (1)

81579b6 Fixes #18916: Fix styling of dynamic dropdowns with invalid selection

📊 Changes

2 files changed (+7 additions, -1 deletions)

View changed files

📝 netbox/project-static/dist/netbox.css (+1 -1)
📝 netbox/project-static/styles/overrides/_tomselect.scss (+6 -0)

📄 Description

Fixes: #18916

This tweaks the CSS so that the .ts-wrapper containers corresponding to each invalid <select> field with .is-invalid applied get the same styling.

Note: I wasn't able to fix the display of the invalid-feedback element beneath the field due to limitations in how Bootstrap implements this. (The <div> needs to immediately follow the offending <select>, which is not possible with the current widget layout.)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20177 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 8/25/2025 **Status:** ✅ Merged **Merged:** 8/26/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `main` ← **Head:** `18916-TomSelect-invalid-styling` --- ### 📝 Commits (1) - [`81579b6`](https://github.com/netbox-community/netbox/commit/81579b6739705e136dec80b10ccfe1069522cd95) Fixes #18916: Fix styling of dynamic dropdowns with invalid selection ### 📊 Changes **2 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/project-static/dist/netbox.css` (+1 -1) 📝 `netbox/project-static/styles/overrides/_tomselect.scss` (+6 -0) </details> ### 📄 Description ### Fixes: #18916 This tweaks the CSS so that the `.ts-wrapper` containers corresponding to each invalid `<select>` field with `.is-invalid` applied get the same styling. Note: I wasn't able to fix the display of the `invalid-feedback` element beneath the field due to limitations in how Bootstrap implements this. (The `<div>` needs to immediately follow the offending `<select>`, which is not possible with the current widget layout.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:24:22 +01:00

adam closed this issue

2025-12-30 00:24:22 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15844