starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20046] [MERGED] Fixes: #19669 & #18396 - Allow Token Authentication against Media view #15810

New Issue
Closed
opened 2025-12-30 00:24:11 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:24:11 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20046
Author: @DanSheps
Created: 8/7/2025
Status: ✅ Merged
Merged: 8/15/2025
Merged by: @arthanson

Base: main ← Head: 19669-allow-token-authenication-against-media-endpoint

📝 Commits (4)

  • 1cb10ee Fixes: #19669 & #18396 - Allow Token Authentication against Media view
  • 244e738 Update media view to preserve the exception.
  • 2192a7d Set request.auth to the Token instance
  • a9e2872 Update per discussion

📊 Changes

2 files changed (+17 additions, -2 deletions)

View changed files

📝 netbox/netbox/views/misc.py (+2 -2)
📝 netbox/utilities/views.py (+15 -0)

📄 Description

Fixes: #19669 & #18396 - Allow Token Authentication against Media view

  • Add reusable TokenConditionalLoginRequiredMixin (inheriting from ConditionalLoginRequiredMixin)
  • Change MediaView to utilize new Mixin

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20046 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 8/7/2025 **Status:** ✅ Merged **Merged:** 8/15/2025 **Merged by:** [@arthanson](https://github.com/arthanson) **Base:** `main` ← **Head:** `19669-allow-token-authenication-against-media-endpoint` --- ### 📝 Commits (4) - [`1cb10ee`](https://github.com/netbox-community/netbox/commit/1cb10eeb4fc2bbd0a60030ecaa69acc9994c1a26) Fixes: #19669 & #18396 - Allow Token Authentication against Media view - [`244e738`](https://github.com/netbox-community/netbox/commit/244e738ebb4f5199695f13eac0e8fb8521a85f6d) Update media view to preserve the exception. - [`2192a7d`](https://github.com/netbox-community/netbox/commit/2192a7d8d74a145c572d97741a16aac1b316b6e8) Set `request.auth` to the `Token` instance - [`a9e2872`](https://github.com/netbox-community/netbox/commit/a9e2872d0f6208d00c7a778c678ebc90d8e26305) Update per discussion ### 📊 Changes **2 files changed** (+17 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/views/misc.py` (+2 -2) 📝 `netbox/utilities/views.py` (+15 -0) </details> ### 📄 Description ### Fixes: #19669 & #18396 - Allow Token Authentication against Media view * Add reusable `TokenConditionalLoginRequiredMixin` (inheriting from `ConditionalLoginRequiredMixin`) * Change MediaView to utilize new Mixin --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:24:11 +01:00
adam closed this issue 2025-12-30 00:24:11 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15810
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?