starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #20041] [MERGED] Fixes: #19645 - Correct Interface selection for Cable add when VC master is the selected device #15808

New Issue
Closed
opened 2025-12-30 00:24:11 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:24:11 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/20041
Author: @DanSheps
Created: 8/7/2025
Status: ✅ Merged
Merged: 8/15/2025
Merged by: @jnovinger

Base: main ← Head: fixes-19645-correct-interface-display-in-cable-add

📝 Commits (3)

  • 1025c22 Fixes: #19645 - Correct Interface selection for Cable add when VC master is the selected device
  • 3298422 Clarify label
  • f18345d Add test

📊 Changes

3 files changed (+37 additions, -3 deletions)

View changed files

📝 netbox/dcim/filtersets.py (+15 -2)
📝 netbox/dcim/forms/connections.py (+6 -1)
📝 netbox/dcim/tests/test_filtersets.py (+16 -0)

📄 Description

Fixes: #19645 - Correct Interface selection for Cable add when VC master is the selected device

  • Add new filter to Interface filterset: virtual_chassis_member_or_master which will only return interfaces in the full VC if the device is a master device
  • Set cable creation form to utilize the new filter

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/20041 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 8/7/2025 **Status:** ✅ Merged **Merged:** 8/15/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `main` ← **Head:** `fixes-19645-correct-interface-display-in-cable-add` --- ### 📝 Commits (3) - [`1025c22`](https://github.com/netbox-community/netbox/commit/1025c227ce8fbf16c352366e983d0eb21c241b7c) Fixes: #19645 - Correct Interface selection for Cable add when VC master is the selected device - [`3298422`](https://github.com/netbox-community/netbox/commit/3298422ce5dc9e08f45b4ef32c2c6b1c91f2d469) Clarify label - [`f18345d`](https://github.com/netbox-community/netbox/commit/f18345d31aeb3124cd44abd2d966cc57c37896f2) Add test ### 📊 Changes **3 files changed** (+37 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/filtersets.py` (+15 -2) 📝 `netbox/dcim/forms/connections.py` (+6 -1) 📝 `netbox/dcim/tests/test_filtersets.py` (+16 -0) </details> ### 📄 Description ### Fixes: #19645 - Correct Interface selection for Cable add when VC master is the selected device * Add new filter to `Interface` filterset: `virtual_chassis_member_or_master` which will only return interfaces in the full VC if the device is a master device * Set cable creation form to utilize the new filter --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:24:11 +01:00
adam closed this issue 2025-12-30 00:24:11 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15808
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?