starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19951] [MERGED] Fix #19910: Add conditional to hide internet dependent links in an isolated deployment #15770

New Issue
Closed
opened 2025-12-30 00:23:57 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:23:57 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19951
Author: @rodvand
Created: 7/24/2025
Status: ✅ Merged
Merged: 7/29/2025
Merged by: @jnovinger

Base: main ← Head: issue_19910

📝 Commits (4)

  • a5d1500 Add conditional to hide internet dependent links in an isolated deployment
  • 576099e Formatting
  • ccec118 Adjust conditional
  • 9063f5f Formatting

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 netbox/templates/base/layout.html (+3 -3)

📄 Description

Fixes: #19910

In the base template, add conditionals on internet links to hide them when the setting ISOLATED_DEPLOYMENT is set to True.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19951 **Author:** [@rodvand](https://github.com/rodvand) **Created:** 7/24/2025 **Status:** ✅ Merged **Merged:** 7/29/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `main` ← **Head:** `issue_19910` --- ### 📝 Commits (4) - [`a5d1500`](https://github.com/netbox-community/netbox/commit/a5d1500307c76f10c444287dad2b315835aca006) Add conditional to hide internet dependent links in an isolated deployment - [`576099e`](https://github.com/netbox-community/netbox/commit/576099e3b87e5ac10352fef0c8552b825bef5adb) Formatting - [`ccec118`](https://github.com/netbox-community/netbox/commit/ccec1182d8281179295553c8d1e3ddd3760d61c5) Adjust conditional - [`9063f5f`](https://github.com/netbox-community/netbox/commit/9063f5faccd140c941c13e5311d57ebc16bbb3a9) Formatting ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/templates/base/layout.html` (+3 -3) </details> ### 📄 Description ### Fixes: #19910 In the base template, add conditionals on internet links to hide them when the setting ISOLATED_DEPLOYMENT is set to True. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:23:57 +01:00
adam closed this issue 2025-12-30 00:23:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15770
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?