starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19922] [MERGED] Fixes #19911: Fix redirect_url support for bulk operations #15758

New Issue
Closed
opened 2025-12-30 00:23:52 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:23:52 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19922
Author: @jeremystretch
Created: 7/21/2025
Status: ✅ Merged
Merged: 7/24/2025
Merged by: @jnovinger

Base: feature ← Head: 19911-fix-bulk-edit-redirect

📝 Commits (2)

  • 8793d42 Establish render() method on ObjectAction
  • 6744a96 Restore support for passing return_url

📊 Changes

8 files changed (+16 additions, -13 deletions)

View changed files

📝 netbox/netbox/object_actions.py (+7 -2)
📝 netbox/templates/core/buttons/bulk_sync.html (+1 -1)
📝 netbox/templates/dcim/buttons/bulk_disconnect.html (+1 -1)
📝 netbox/templates/generic/object_children.html (+1 -1)
📝 netbox/utilities/templates/buttons/bulk_delete.html (+1 -1)
📝 netbox/utilities/templates/buttons/bulk_edit.html (+1 -1)
📝 netbox/utilities/templates/buttons/bulk_rename.html (+1 -1)
📝 netbox/utilities/templatetags/buttons.py (+3 -5)

📄 Description

Fixes: #19911

  • Move the template rendering logic to a render() method on the ObjectAction class
  • Extend action_buttons template tag to support passing arbitrary keyword arguments
  • Extend bulk operation button templates to attach a return URL parameter to the target URL if one was given

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19922 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 7/21/2025 **Status:** ✅ Merged **Merged:** 7/24/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `feature` ← **Head:** `19911-fix-bulk-edit-redirect` --- ### 📝 Commits (2) - [`8793d42`](https://github.com/netbox-community/netbox/commit/8793d42b7fb75ec2648c5290a13184ff877169bd) Establish render() method on ObjectAction - [`6744a96`](https://github.com/netbox-community/netbox/commit/6744a96652a5d77a8998aa2ecf8e4ce125eb2976) Restore support for passing return_url ### 📊 Changes **8 files changed** (+16 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/object_actions.py` (+7 -2) 📝 `netbox/templates/core/buttons/bulk_sync.html` (+1 -1) 📝 `netbox/templates/dcim/buttons/bulk_disconnect.html` (+1 -1) 📝 `netbox/templates/generic/object_children.html` (+1 -1) 📝 `netbox/utilities/templates/buttons/bulk_delete.html` (+1 -1) 📝 `netbox/utilities/templates/buttons/bulk_edit.html` (+1 -1) 📝 `netbox/utilities/templates/buttons/bulk_rename.html` (+1 -1) 📝 `netbox/utilities/templatetags/buttons.py` (+3 -5) </details> ### 📄 Description ### Fixes: #19911 - Move the template rendering logic to a `render()` method on the ObjectAction class - Extend `action_buttons` template tag to support passing arbitrary keyword arguments - Extend bulk operation button templates to attach a return URL parameter to the target URL if one was given --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:23:52 +01:00
adam closed this issue 2025-12-30 00:23:52 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15758
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?