starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19900] [MERGED] Closes: #18588: Relabel Service to Application Service #15753

New Issue
Closed
opened 2025-12-30 00:23:50 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:23:50 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19900
Author: @jnovinger
Created: 7/16/2025
Status: ✅ Merged
Merged: 7/21/2025
Merged by: @jeremystretch

Base: feature ← Head: 18588-tweak-service-labels

📝 Commits (5)

  • a97a4e9 Closes: #18588: Relabel Service model to Application Service
  • bc3a06a Rename to Application Services/Application Service Templates in nav menu
  • 0545c57 Rename ~service to ~'Application Service' in templates
  • 885b802 Change ~service to ~'application service' hardcoded strings in Python files
  • 22560be Update ~service to ~'application service' in docs

📊 Changes

15 files changed (+56 additions, -33 deletions)

View changed files

📝 docs/features/ipam.md (+2 -2)
📝 docs/models/ipam/service.md (+8 -4)
📝 docs/models/ipam/servicetemplate.md (+6 -2)
📝 docs/models/virtualization/vminterface.md (+1 -1)
📝 netbox/ipam/filtersets.py (+1 -1)
📝 netbox/ipam/forms/model_forms.py (+7 -5)
📝 netbox/ipam/models/services.py (+5 -5)
📝 netbox/ipam/tests/test_api.py (+2 -0)
📝 netbox/ipam/tests/test_filtersets.py (+3 -0)
📝 netbox/netbox/navigation/menu.py (+2 -2)
📝 netbox/templates/dcim/device.html (+2 -2)
📝 netbox/templates/ipam/ipaddress.html (+1 -1)
📝 netbox/templates/ipam/servicetemplate.html (+1 -1)
📝 netbox/templates/virtualization/virtualmachine.html (+2 -2)
📝 netbox/utilities/testing/filtersets.py (+13 -5)

📄 Description

Closes: #18588

This PR relabels the Service model to "Application Service" (and ServiceTemplate to "Application Service Template") throughout the UI to make it clearer what this model is actually for.

"Application Service" was chosen because it best describes the model's intent: to represent pretty much anything running above the transport layer (L4). This includes classic examples like SSH, HTTPS, and NTP, but also custom applications, APIs, or any other process defined by a protocol and port. The name "L7 Service" was considered, but it felt a little too restrictive and could be confusing for users who also interact with programmatic aspects of NetBox.

To ensure backward compatibility, this is a UI-only change. The underlying models, REST API endpoints, and GraphQL schema remain unchanged.
TODO:

  • Update Service and ServiceTemplate verbose_name and adapt test suites (django-filter, GraphQL) to assert API stability.
  • Rename Service and Service template in the IPAM sub-menu.
  • Update hardcoded labels for buttons, titles, and messages across all relevant templates, views, forms, and tables.
  • Update docs as necessary.
  • Optional: work to make sure translations exist This should be covered by routine Transifex maintenance.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19900 **Author:** [@jnovinger](https://github.com/jnovinger) **Created:** 7/16/2025 **Status:** ✅ Merged **Merged:** 7/21/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `18588-tweak-service-labels` --- ### 📝 Commits (5) - [`a97a4e9`](https://github.com/netbox-community/netbox/commit/a97a4e9f2378eb03a3597099d6c8cbb8405dfcec) Closes: #18588: Relabel Service model to Application Service - [`bc3a06a`](https://github.com/netbox-community/netbox/commit/bc3a06a35e6d6b938ef96f96ade42343837f7605) Rename to Application Services/Application Service Templates in nav menu - [`0545c57`](https://github.com/netbox-community/netbox/commit/0545c571ee566f69561c6afad8dff5cd2debaded) Rename ~service to ~'Application Service' in templates - [`885b802`](https://github.com/netbox-community/netbox/commit/885b802ae41269e5b008b57e4077aa27631e3ead) Change ~service to ~'application service' hardcoded strings in Python files - [`22560be`](https://github.com/netbox-community/netbox/commit/22560be8a2b04bbaf980e4aa4f7770f0909ca327) Update ~service to ~'application service' in docs ### 📊 Changes **15 files changed** (+56 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `docs/features/ipam.md` (+2 -2) 📝 `docs/models/ipam/service.md` (+8 -4) 📝 `docs/models/ipam/servicetemplate.md` (+6 -2) 📝 `docs/models/virtualization/vminterface.md` (+1 -1) 📝 `netbox/ipam/filtersets.py` (+1 -1) 📝 `netbox/ipam/forms/model_forms.py` (+7 -5) 📝 `netbox/ipam/models/services.py` (+5 -5) 📝 `netbox/ipam/tests/test_api.py` (+2 -0) 📝 `netbox/ipam/tests/test_filtersets.py` (+3 -0) 📝 `netbox/netbox/navigation/menu.py` (+2 -2) 📝 `netbox/templates/dcim/device.html` (+2 -2) 📝 `netbox/templates/ipam/ipaddress.html` (+1 -1) 📝 `netbox/templates/ipam/servicetemplate.html` (+1 -1) 📝 `netbox/templates/virtualization/virtualmachine.html` (+2 -2) 📝 `netbox/utilities/testing/filtersets.py` (+13 -5) </details> ### 📄 Description ### Closes: #18588 This PR relabels the Service model to "Application Service" (and ServiceTemplate to "Application Service Template") throughout the UI to make it clearer what this model is actually for. "Application Service" was chosen because it best describes the model's intent: to represent pretty much anything running above the transport layer (L4). This includes classic examples like SSH, HTTPS, and NTP, but also custom applications, APIs, or any other process defined by a protocol and port. The name "L7 Service" was considered, but it felt a little too restrictive and could be confusing for users who also interact with programmatic aspects of NetBox. To ensure backward compatibility, this is a UI-only change. The underlying models, REST API endpoints, and GraphQL schema remain unchanged. TODO: - [x] Update Service and ServiceTemplate verbose_name and adapt test suites (django-filter, GraphQL) to assert API stability. - [x] Rename Service and Service template in the IPAM sub-menu. - [x] Update hardcoded labels for buttons, titles, and messages across all relevant templates, views, forms, and tables. - [x] Update docs as necessary. - ~~Optional: work to make sure translations exist~~ This should be covered by routine Transifex maintenance. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:23:50 +01:00
adam closed this issue 2025-12-30 00:23:51 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15753
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?