[PR #19885] [MERGED] Fixes #19633: Log all evaluations of invalid event rule conditions #15746

New Issue

adam · 2025-12-30T00:23:48+01:00

adam commented

2025-12-30 00:23:48 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19885
Author: @jeremystretch
Created: 7/15/2025
Status: ✅ Merged
Merged: 7/15/2025
Merged by: @jnovinger

Base: main ← Head: 19633-eventrule-invalid-condition

📝 Commits (3)

2d59a2e flush_events() should catch only import errors
9daf70d Fixes #19633: Log all evaluations of invalid event rule conditions
90fc3f6 Correct comment

📊 Changes

5 files changed (+48 additions, -21 deletions)

View changed files

📝 docs/configuration/system.md (+1 -0)
📝 netbox/extras/conditions.py (+15 -8)
📝 netbox/extras/events.py (+1 -1)
📝 netbox/extras/models/models.py (+10 -2)
📝 netbox/extras/tests/test_conditions.py (+21 -10)

📄 Description

Fixes: #19633

Avoid catching unintended exceptions under flush_events()
Introduce the InvalidCondition exception
Raise InvalidCondition whenever an invalid event rule condition is encountered
Catch and log invalid conditions

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19885 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 7/15/2025 **Status:** ✅ Merged **Merged:** 7/15/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `main` ← **Head:** `19633-eventrule-invalid-condition` --- ### 📝 Commits (3) - [`2d59a2e`](https://github.com/netbox-community/netbox/commit/2d59a2e1ec7ece0b7e517b10faeb57f3c5778df2) flush_events() should catch only import errors - [`9daf70d`](https://github.com/netbox-community/netbox/commit/9daf70d7140cf86930252d7aee108f3ca2cd1f18) Fixes #19633: Log all evaluations of invalid event rule conditions - [`90fc3f6`](https://github.com/netbox-community/netbox/commit/90fc3f6653e344a1c2a42b7347cb8502d6c6378e) Correct comment ### 📊 Changes **5 files changed** (+48 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `docs/configuration/system.md` (+1 -0) 📝 `netbox/extras/conditions.py` (+15 -8) 📝 `netbox/extras/events.py` (+1 -1) 📝 `netbox/extras/models/models.py` (+10 -2) 📝 `netbox/extras/tests/test_conditions.py` (+21 -10) </details> ### 📄 Description ### Fixes: #19633 - Avoid catching unintended exceptions under `flush_events()` - Introduce the InvalidCondition exception - Raise InvalidCondition whenever an invalid event rule condition is encountered - Catch and log invalid conditions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:23:48 +01:00

adam closed this issue

2025-12-30 00:23:49 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15746