starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19681] [MERGED] #19680 fix deletion dependency order for GenericRelations #15705

New Issue
Closed
opened 2025-12-30 00:23:32 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:23:32 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19681
Author: @arthanson
Created: 6/7/2025
Status: ✅ Merged
Merged: 6/13/2025
Merged by: @jnovinger

Base: main ← Head: 19680-object-change

📝 Commits (9)

📊 Changes

4 files changed (+175 additions, -2 deletions)

View changed files

📝 netbox/core/signals.py (+6 -0)
📝 netbox/core/tests/test_changelog.py (+77 -1)
➕ netbox/netbox/models/deletion.py (+90 -0)
📝 netbox/netbox/models/features.py (+2 -1)

📄 Description

Fixes: #19680

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19681 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 6/7/2025 **Status:** ✅ Merged **Merged:** 6/13/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `main` ← **Head:** `19680-object-change` --- ### 📝 Commits (9) - [`a23a0f2`](https://github.com/netbox-community/netbox/commit/a23a0f2708cd3c62b729c4caf4fe72e9906984a1) #19680 fix deletion dependency order for GenericRelations - [`cf4f098`](https://github.com/netbox-community/netbox/commit/cf4f0982c5d8d265a927c1d544c0abf329cec542) 19680 add test - [`21f3007`](https://github.com/netbox-community/netbox/commit/21f30070e6403f3eb4542fb242098093b162d8f4) 19680 fix Collector and test - [`fd9decc`](https://github.com/netbox-community/netbox/commit/fd9decce04b4d1729d6e4072369101921ef02d4e) 19680 put on changeloggingmixin - [`ffae0df`](https://github.com/netbox-community/netbox/commit/ffae0df80817898ee09a2ae07d9c3058f713bd16) 19680 cleanup - [`aa21e0f`](https://github.com/netbox-community/netbox/commit/aa21e0ff558a712bcbea65a9e1ece41f7f006e55) 19680 cleanup - [`5334fd7`](https://github.com/netbox-community/netbox/commit/5334fd78493496587010f2f7e16be984f2a73642) 19680 cleanup - [`1c71107`](https://github.com/netbox-community/netbox/commit/1c71107a44b9d2f6ef335fd8109806b0e067b9c7) 19680 skip changelog update for deleted objects - [`289d11c`](https://github.com/netbox-community/netbox/commit/289d11c6bbf868301044b76f158a1949d968be5c) 19680 remove print ### 📊 Changes **4 files changed** (+175 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/core/signals.py` (+6 -0) 📝 `netbox/core/tests/test_changelog.py` (+77 -1) ➕ `netbox/netbox/models/deletion.py` (+90 -0) 📝 `netbox/netbox/models/features.py` (+2 -1) </details> ### 📄 Description ### Fixes: #19680 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:23:32 +01:00
adam closed this issue 2025-12-30 00:23:32 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15705
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?