starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19495] [MERGED] Fixes #19415: Increased Circuit/WirelessLink distance upper limit #15665

New Issue
Closed
opened 2025-12-30 00:23:17 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:23:17 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19495
Author: @jnovinger
Created: 5/14/2025
Status: ✅ Merged
Merged: 5/19/2025
Merged by: @jeremystretch

Base: main ← Head: 19415-circuit-wirelesslink-distance-extension

📝 Commits (8)

  • 7e1d558 Fixes #19415: Increased Circuit/WirelessLink absolute distance upper limit
  • 82c574c Include forgotten migration files
  • 4f0874c Remove unnecessary comments
  • 18b7a31 Remove more unnecessary comments
  • b4e15b6 Addresses PR feedback
  • a3adb6d Gah, remove django migration header comment
  • cb82810 Clean up new has_field_errors mechanism, fix issue with ObjectAttribute
  • c68b739 Address PR feedback, revert changes to render_fieldset template tag

📊 Changes

7 files changed (+57 additions, -4 deletions)

View changed files

📝 netbox/circuits/forms/model_forms.py (+2 -1)
➕ netbox/circuits/migrations/0052_extend_circuit_abs_distance_upper_limit.py (+16 -0)
📝 netbox/netbox/models/mixins.py (+3 -2)
📝 netbox/utilities/forms/mixins.py (+13 -0)
📝 netbox/utilities/templates/form_helpers/render_fieldset.html (+5 -0)
📝 netbox/wireless/forms/model_forms.py (+2 -1)
➕ netbox/wireless/migrations/0015_extend_wireless_link_abs_distance_upper_limit.py (+16 -0)

📄 Description

Fixes: #19415

  • Increases the longest possible distance for Circuits and WirelessLink to accommodate distances up to 100,000 miles (normalize to an upper limit of 160,934,000 meters)
  • Adds form validation to provide useful feedback to user when exceeding distance upper limit
  • Fixes a bug discovered during development where field errors for items in an InlineFields object were not displayed correctly

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19495 **Author:** [@jnovinger](https://github.com/jnovinger) **Created:** 5/14/2025 **Status:** ✅ Merged **Merged:** 5/19/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `19415-circuit-wirelesslink-distance-extension` --- ### 📝 Commits (8) - [`7e1d558`](https://github.com/netbox-community/netbox/commit/7e1d558428a389f13958cb51b83d3205febadcf1) Fixes #19415: Increased Circuit/WirelessLink absolute distance upper limit - [`82c574c`](https://github.com/netbox-community/netbox/commit/82c574cc5170472755b19dc11eabde280d4ef22b) Include forgotten migration files - [`4f0874c`](https://github.com/netbox-community/netbox/commit/4f0874cc3a5d78e9ec0a38161782f6874b440c3a) Remove unnecessary comments - [`18b7a31`](https://github.com/netbox-community/netbox/commit/18b7a3187a9d8a501531bdbd4ade26217357c566) Remove more unnecessary comments - [`b4e15b6`](https://github.com/netbox-community/netbox/commit/b4e15b6730b4b9d316ac6b22a9ad6951e9af5fab) Addresses PR feedback - [`a3adb6d`](https://github.com/netbox-community/netbox/commit/a3adb6de482f131d07bf0abb8f0afc4fbcbeccc2) Gah, remove django migration header comment - [`cb82810`](https://github.com/netbox-community/netbox/commit/cb82810b2741e287e40e11e134da1d5c6164f659) Clean up new has_field_errors mechanism, fix issue with ObjectAttribute - [`c68b739`](https://github.com/netbox-community/netbox/commit/c68b739d0a0965ee0d65d35be70cb7281d177fcd) Address PR feedback, revert changes to render_fieldset template tag ### 📊 Changes **7 files changed** (+57 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/forms/model_forms.py` (+2 -1) ➕ `netbox/circuits/migrations/0052_extend_circuit_abs_distance_upper_limit.py` (+16 -0) 📝 `netbox/netbox/models/mixins.py` (+3 -2) 📝 `netbox/utilities/forms/mixins.py` (+13 -0) 📝 `netbox/utilities/templates/form_helpers/render_fieldset.html` (+5 -0) 📝 `netbox/wireless/forms/model_forms.py` (+2 -1) ➕ `netbox/wireless/migrations/0015_extend_wireless_link_abs_distance_upper_limit.py` (+16 -0) </details> ### 📄 Description <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be approved and assigned prior to opening a pull request. This helps avoid waste time and effort on a proposed change that we might not be able to accept. IF YOUR PULL REQUEST DOES NOT REFERENCE AN ISSUE WHICH HAS BEEN ASSIGNED TO YOU, IT WILL BE CLOSED AUTOMATICALLY. Please specify your assigned issue number on the line below. --> ### Fixes: #19415 - Increases the longest possible distance for Circuits and WirelessLink to accommodate distances up to 100,000 miles (normalize to an upper limit of 160,934,000 meters) - Adds form validation to provide useful feedback to user when exceeding distance upper limit - Fixes a bug discovered during development where field errors for items in an InlineFields object were not displayed correctly <!-- Please include a summary of the proposed changes below. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:23:17 +01:00
adam closed this issue 2025-12-30 00:23:17 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15665
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?