starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19390] [MERGED] 19380 call configure on embedded tables #15639

New Issue
Closed
opened 2025-12-30 00:23:09 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:23:09 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19390
Author: @arthanson
Created: 5/2/2025
Status: ✅ Merged
Merged: 5/5/2025
Merged by: @jeremystretch

Base: main ← Head: 19380-sub-tables

📝 Commits (3)

  • 7672ad7 19380 call configure on embedded tables
  • b20d277 19380 call configure on embedded tables
  • 52e9af9 19380 call configure on embedded tables

📊 Changes

7 files changed (+27 additions, -0 deletions)

View changed files

📝 netbox/account/views.py (+1 -0)
📝 netbox/core/views.py (+1 -0)
📝 netbox/dcim/views.py (+5 -0)
📝 netbox/ipam/views.py (+13 -0)
📝 netbox/users/views.py (+1 -0)
📝 netbox/virtualization/views.py (+4 -0)
📝 netbox/vpn/views.py (+2 -0)

📄 Description

Fixes: #19380

Due to changes .configure needs to be called on tables when they are instantiated in views to set default columns, there were a bunch of missing ones. Here are the views changed:

ObjectChangeView
InterfaceView
VRFView
PrefixView
IPRangeView
IPAddressView
FHRPGroupView
VLANView
VMInterfaceView
ProfileView
IPAddressAssignView
VLANTranslationPolicyView
UserView
ClusterRemoveDevicesView
VMInterfaceView
L2VPNView

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19390 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 5/2/2025 **Status:** ✅ Merged **Merged:** 5/5/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `19380-sub-tables` --- ### 📝 Commits (3) - [`7672ad7`](https://github.com/netbox-community/netbox/commit/7672ad74e9d11d3c05d936ef6a3724fa7e9d4d15) 19380 call configure on embedded tables - [`b20d277`](https://github.com/netbox-community/netbox/commit/b20d2770d8065282a1fa2021eb2c22fead77e3f6) 19380 call configure on embedded tables - [`52e9af9`](https://github.com/netbox-community/netbox/commit/52e9af926f2c3ed2ccf551c85ce833cc4a8db7ec) 19380 call configure on embedded tables ### 📊 Changes **7 files changed** (+27 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/account/views.py` (+1 -0) 📝 `netbox/core/views.py` (+1 -0) 📝 `netbox/dcim/views.py` (+5 -0) 📝 `netbox/ipam/views.py` (+13 -0) 📝 `netbox/users/views.py` (+1 -0) 📝 `netbox/virtualization/views.py` (+4 -0) 📝 `netbox/vpn/views.py` (+2 -0) </details> ### 📄 Description ### Fixes: #19380 Due to changes .configure needs to be called on tables when they are instantiated in views to set default columns, there were a bunch of missing ones. Here are the views changed: ObjectChangeView InterfaceView VRFView PrefixView IPRangeView IPAddressView FHRPGroupView VLANView VMInterfaceView ProfileView IPAddressAssignView VLANTranslationPolicyView UserView ClusterRemoveDevicesView VMInterfaceView L2VPNView --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:23:09 +01:00
adam closed this issue 2025-12-30 00:23:09 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15639
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?