starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19369] [MERGED] Closes: #19200 Add Virtual Chassis name to pane on Device View #15634

New Issue
Closed
opened 2025-12-30 00:23:07 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:23:07 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19369
Author: @renatoalmeidaoliveira
Created: 5/1/2025
Status: ✅ Merged
Merged: 5/14/2025
Merged by: @jeremystretch

Base: main ← Head: 19200-Add-Virtual-Chassis-name-to-pane-on-Device-View

📝 Commits (3)

  • 653452d Add virtual chassis information to device template
  • 4db5c6d Merge branch 'main' into 19200-Add-Virtual-Chassis-name-to-pane-on-Device-View
  • 88985e2 Address PR feedback

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 netbox/templates/dcim/device.html (+6 -0)

📄 Description

Closes: #19200 Add Virtual Chassis name to pane on Device View

  • Added the Virtual Chassis information under the Device card.

Observations

When I added that data to the Virtual Chassis card, it looked very different from the general UI. I mean, users normally don't expect to see a device name in the card header.

If I add that information there to follow the usual behavior, I should add it as a clickable link. However, this would be redundant, considering the View Virtual Chassis link already present in that pane.

So, adding that information in the Device card next to the Rack information makes more sense to me.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19369 **Author:** [@renatoalmeidaoliveira](https://github.com/renatoalmeidaoliveira) **Created:** 5/1/2025 **Status:** ✅ Merged **Merged:** 5/14/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `19200-Add-Virtual-Chassis-name-to-pane-on-Device-View` --- ### 📝 Commits (3) - [`653452d`](https://github.com/netbox-community/netbox/commit/653452d66cab0a3c8350df42dd1f916eaad341c7) Add virtual chassis information to device template - [`4db5c6d`](https://github.com/netbox-community/netbox/commit/4db5c6de19abd8d9843d205bf48c7955a256a78d) Merge branch 'main' into 19200-Add-Virtual-Chassis-name-to-pane-on-Device-View - [`88985e2`](https://github.com/netbox-community/netbox/commit/88985e2c374e19de5836c59782f8aa6fcd7ef173) Address PR feedback ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/templates/dcim/device.html` (+6 -0) </details> ### 📄 Description ### Closes: #19200 Add Virtual Chassis name to pane on Device View - Added the Virtual Chassis information under the `Device` card. **Observations** When I added that data to the `Virtual Chassis` card, it looked very different from the general UI. I mean, users normally don't expect to see a device name in the card header. If I add that information there to follow the usual behavior, I should add it as a clickable link. However, this would be redundant, considering the `View Virtual Chassis` link already present in that pane. So, adding that information in the `Device` card next to the `Rack` information makes more sense to me. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:23:07 +01:00
adam closed this issue 2025-12-30 00:23:07 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15634
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?