starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19357] [MERGED] Fixes #17319: Arrange device and module type fields behind tab in com… #15628

New Issue
Closed
opened 2025-12-30 00:23:05 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:23:05 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19357
Author: @jnovinger
Created: 4/29/2025
Status: ✅ Merged
Merged: 4/30/2025
Merged by: @bctiemann

Base: main ← Head: 17319-device-and-module-type-behind-tabs

📝 Commits (1)

  • 964ae56 Fixes #17319: Arrange device and module type fields behind tab in component template forms

📊 Changes

2 files changed (+55 additions, -18 deletions)

View changed files

📝 netbox/dcim/forms/model_forms.py (+47 -16)
📝 netbox/dcim/forms/object_create.py (+8 -2)

📄 Description

…ponent template forms

Fixes: #17319

  • Updates all device/module component template forms (but only those that display both fields) to arrange device_type and module_type fields in a tabbed group.
  • Included module component templates forms even though the initial ticket only specified device component template forms, since most of them are shared forms.
  • Contemplated creating a re-usable sub-Fieldset definition and plugging that in, but it seemed less readable plus I didn't see us doing anything like that elsewhere.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19357 **Author:** [@jnovinger](https://github.com/jnovinger) **Created:** 4/29/2025 **Status:** ✅ Merged **Merged:** 4/30/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `main` ← **Head:** `17319-device-and-module-type-behind-tabs` --- ### 📝 Commits (1) - [`964ae56`](https://github.com/netbox-community/netbox/commit/964ae56d34b1f97bc147224c9730dcd80ad9a938) Fixes #17319: Arrange device and module type fields behind tab in component template forms ### 📊 Changes **2 files changed** (+55 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms/model_forms.py` (+47 -16) 📝 `netbox/dcim/forms/object_create.py` (+8 -2) </details> ### 📄 Description …ponent template forms <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be approved and assigned prior to opening a pull request. This helps avoid waste time and effort on a proposed change that we might not be able to accept. IF YOUR PULL REQUEST DOES NOT REFERENCE AN ISSUE WHICH HAS BEEN ASSIGNED TO YOU, IT WILL BE CLOSED AUTOMATICALLY. Please specify your assigned issue number on the line below. --> ### Fixes: #17319 - Updates all device/module component template forms (but only those that display both fields) to arrange `device_type` and `module_type` fields in a tabbed group. - Included module component templates forms even though the initial ticket only specified device component template forms, since most of them are shared forms. - Contemplated creating a re-usable sub-Fieldset definition and plugging that in, but it seemed less readable plus I didn't see us doing anything like that elsewhere. <!-- Please include a summary of the proposed changes below. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:23:05 +01:00
adam closed this issue 2025-12-30 00:23:05 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15628
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?