[PR #19356] [MERGED] Fixes #15739: Account for parallel cables when calculating total path length #15627

Closed
opened 2025-12-30 00:23:04 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19356
Author: @jeremystretch
Created: 4/29/2025
Status: Merged
Merged: 4/29/2025
Merged by: @jnovinger

Base: mainHead: 15739-cable-trace-lengths


📝 Commits (1)

  • 74f4d8e Fixes #15739: Account for parallel cables when calculating total path length

📊 Changes

2 files changed (+22 additions, -4 deletions)

View changed files

📝 netbox/dcim/models/cables.py (+21 -3)
📝 netbox/templates/dcim/cable_trace.html (+1 -1)

📄 Description

Fixes: #15739

Pre-fetch cable lengths, then iterate through the path, adding the longest cable at each hop to the total path length


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19356 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 4/29/2025 **Status:** ✅ Merged **Merged:** 4/29/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `main` ← **Head:** `15739-cable-trace-lengths` --- ### 📝 Commits (1) - [`74f4d8e`](https://github.com/netbox-community/netbox/commit/74f4d8e8ec24448866542948efb0475b8ba0e73b) Fixes #15739: Account for parallel cables when calculating total path length ### 📊 Changes **2 files changed** (+22 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/models/cables.py` (+21 -3) 📝 `netbox/templates/dcim/cable_trace.html` (+1 -1) </details> ### 📄 Description ### Fixes: #15739 Pre-fetch cable lengths, then iterate through the path, adding the longest cable at each hop to the total path length --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:23:04 +01:00
adam closed this issue 2025-12-30 00:23:05 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15627