[PR #19301] [MERGED] Fixes: #19229 Validade interface mode changes #15603

New Issue

adam · 2025-12-30T00:22:57+01:00

adam commented

2025-12-30 00:22:57 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19301
Author: @renatoalmeidaoliveira
Created: 4/24/2025
Status: ✅ Merged
Merged: 4/28/2025
Merged by: @bctiemann

Base: main ← Head: 19229-cant-unset-a-device-interface-vlan-mode-without-an-error

📝 Commits (1)

125bce8 Validade interface mode changes

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 netbox/dcim/forms/common.py (+6 -1)

📄 Description

Fixes: #19229 cant unset a device interface vlan mode without an error

When the user changes the Interface mode, the untagged_vlan and tagged_vlans fields are unset and excluded from the InterfaceForm data.
Since the form instance is derived from a copy of the concrete object, the untagged_vlan and tagged_vlans remain untouched even when the mode field is modified, leading to a validation error when updating the model.
The fix ensures that when the form instance's mode field differs from cleaned_data["mode"], these fields are properly removed from the instance when unset, preventing validation errors.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19301 **Author:** [@renatoalmeidaoliveira](https://github.com/renatoalmeidaoliveira) **Created:** 4/24/2025 **Status:** ✅ Merged **Merged:** 4/28/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `main` ← **Head:** `19229-cant-unset-a-device-interface-vlan-mode-without-an-error` --- ### 📝 Commits (1) - [`125bce8`](https://github.com/netbox-community/netbox/commit/125bce84e467ec8a5342031899803e4b22562f10) Validade interface mode changes ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms/common.py` (+6 -1) </details> ### 📄 Description ### Fixes: #19229 cant unset a device interface vlan mode without an error - When the user changes the `Interface` mode, the `untagged_vlan` and `tagged_vlans` fields are unset and excluded from the `InterfaceForm` data. - Since the form instance is derived from a copy of the concrete object, the `untagged_vlan` and `tagged_vlans` remain untouched even when the `mode` field is modified, leading to a validation error when updating the model. - The fix ensures that when the form instance's `mode` field differs from `cleaned_data["mode"]`, these fields are properly removed from the instance when unset, preventing validation errors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:22:57 +01:00

adam closed this issue

2025-12-30 00:22:57 +01:00

Sign in to join this conversation.

Branches Tags

main

21142-device-component-graphql-filters

21050-device-oob-ip-may-become-orphaned

21102-fix-graphiql-explorer

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15603