starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19290] [MERGED] 16238 map custom-link button colors to tabler #15599

New Issue
Closed
opened 2025-12-30 00:22:56 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:22:56 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19290
Author: @arthanson
Created: 4/23/2025
Status: ✅ Merged
Merged: 4/24/2025
Merged by: @jeremystretch

Base: main ← Head: 16238-button-color

📝 Commits (4)

  • 9065667 16238 map custom-link button colors to tabler
  • bb0a62c 16238 map custom-link button colors to tabler
  • 39272b4 16238 backout temp code
  • 4416fdb 16238 optimize

📊 Changes

2 files changed (+13 additions, -1 deletions)

View changed files

📝 netbox/project-static/dist/netbox.css (+1 -1)
📝 netbox/project-static/styles/custom/_misc.scss (+12 -0)

📄 Description

Fixes: #16238

Adds CSS styling for missing btn-white, btn-black, btn-grey. Note CSS extend doesn't catch all potential styling on elements depending on how the selectors are defined (see https://stackoverflow.com/questions/13335544/how-to-alias-class-name-in-css-or-sass) but it appears all the styling is good for these buttons.

Note: ghost-dark (used for LINK type) is a tabler button but in the version of tabler we use link text doesn't display in dark mode, should be fixed in latest version of tabler.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19290 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 4/23/2025 **Status:** ✅ Merged **Merged:** 4/24/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `16238-button-color` --- ### 📝 Commits (4) - [`9065667`](https://github.com/netbox-community/netbox/commit/9065667ddf702daf76364855e9de0f5de0a9d06b) 16238 map custom-link button colors to tabler - [`bb0a62c`](https://github.com/netbox-community/netbox/commit/bb0a62c837265ca23f1a4ec39c8704e9afbe7f7d) 16238 map custom-link button colors to tabler - [`39272b4`](https://github.com/netbox-community/netbox/commit/39272b4cbc28e52c9df98a8febb72c9f8e275706) 16238 backout temp code - [`4416fdb`](https://github.com/netbox-community/netbox/commit/4416fdbf69da1983db1c515af7d16372773f4c2e) 16238 optimize ### 📊 Changes **2 files changed** (+13 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/project-static/dist/netbox.css` (+1 -1) 📝 `netbox/project-static/styles/custom/_misc.scss` (+12 -0) </details> ### 📄 Description ### Fixes: #16238 Adds CSS styling for missing btn-white, btn-black, btn-grey. Note CSS extend doesn't catch all potential styling on elements depending on how the selectors are defined (see https://stackoverflow.com/questions/13335544/how-to-alias-class-name-in-css-or-sass) but it appears all the styling is good for these buttons. Note: ghost-dark (used for LINK type) is a tabler button but in the version of tabler we use link text doesn't display in dark mode, should be fixed in latest version of tabler. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:22:56 +01:00
adam closed this issue 2025-12-30 00:22:56 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15599
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?