starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19256] [MERGED] Fixes #18959: Preserve ordering of terminations in cable traces #15585

New Issue
Closed
opened 2025-12-30 00:22:51 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:22:51 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19256
Author: @jeremystretch
Created: 4/22/2025
Status: ✅ Merged
Merged: 4/22/2025
Merged by: @bctiemann

Base: main ← Head: 18959-cable-trace-terminations-ordering

📝 Commits (2)

  • 459c4bf Fixes #18959: Preserve ordering of terminations in cable traces
  • 8567aa9 Remove obsolete comment

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 netbox/dcim/svg/cables.py (+1 -2)

📄 Description

Fixes: #18959

Remove the call to sorted() as terminations should already be ordered naturally.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19256 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 4/22/2025 **Status:** ✅ Merged **Merged:** 4/22/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `main` ← **Head:** `18959-cable-trace-terminations-ordering` --- ### 📝 Commits (2) - [`459c4bf`](https://github.com/netbox-community/netbox/commit/459c4bfd9d84fb7f0663f2eaa9f1c9c29dc7b804) Fixes #18959: Preserve ordering of terminations in cable traces - [`8567aa9`](https://github.com/netbox-community/netbox/commit/8567aa96e479174a71317e3cd0132c19ba035e49) Remove obsolete comment ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/svg/cables.py` (+1 -2) </details> ### 📄 Description ### Fixes: #18959 Remove the call to `sorted()` as terminations should already be ordered naturally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:22:51 +01:00
adam closed this issue 2025-12-30 00:22:51 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15585
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?