starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 13:00:30 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19157] [CLOSED] Fixes: #19150 - Populate STORAGE_CONFIG into STORAGES['default']['OPTIONS'] #15550

New Issue
Closed
opened 2025-12-30 00:22:37 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:22:37 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19157
Author: @bctiemann
Created: 4/11/2025
Status: ❌ Closed

Base: main ← Head: 19150-populate-OPTIONS-from-STORAGE_CONFIG

📝 Commits (2)

  • cdb5ee2 Populate STORAGE_CONFIG into STORAGES['default']['OPTIONS']
  • ba5769f Merge default STORAGES with setting from configuration.py

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 netbox/netbox/settings.py (+1 -0)

📄 Description

Fixes: #19150

Fixes an oversight in support for Django 4.2's STORAGES in that STORAGE_CONFIG was not being populated into STORAGES['default']['OPTIONS'] as well as being monkey-patched into storages.utils.setting as in the pre-Django-4.2 behavior. This fix ensures that both styles of backend will be supported.

Note that this support will be obviated/deprecated in NetBox v4.3 which allows STORAGES to be specified directly in configuration.py.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19157 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 4/11/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `19150-populate-OPTIONS-from-STORAGE_CONFIG` --- ### 📝 Commits (2) - [`cdb5ee2`](https://github.com/netbox-community/netbox/commit/cdb5ee202a67eaa513e0bad1367d56454797b5fb) Populate STORAGE_CONFIG into STORAGES['default']['OPTIONS'] - [`ba5769f`](https://github.com/netbox-community/netbox/commit/ba5769f25684125cec81f65f4ef6613c776763bc) Merge default STORAGES with setting from configuration.py ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/settings.py` (+1 -0) </details> ### 📄 Description ### Fixes: #19150 Fixes an oversight in support for Django 4.2's `STORAGES` in that `STORAGE_CONFIG` was not being populated into `STORAGES['default']['OPTIONS']` as well as being monkey-patched into `storages.utils.setting` as in the pre-Django-4.2 behavior. This fix ensures that both styles of backend will be supported. Note that this support will be obviated/deprecated in NetBox v4.3 which allows `STORAGES` to be specified directly in `configuration.py`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:22:37 +01:00
adam closed this issue 2025-12-30 00:22:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15550
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?