[PR #19155] [MERGED] #14591, #17841: Adjust default weighting #15545

Closed
opened 2025-12-30 00:22:35 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19155
Author: @jeremystretch
Created: 4/11/2025
Status: Merged
Merged: 4/11/2025
Merged by: @jnovinger

Base: featureHead: adjust-default-weights


📝 Commits (2)

📊 Changes

6 files changed (+17 additions, -20 deletions)

View changed files

📝 netbox/extras/migrations/0125_alter_tag_options_tag_weight.py (+1 -1)
📝 netbox/extras/migrations/0128_tableconfig.py (+1 -1)
📝 netbox/extras/models/models.py (+1 -1)
📝 netbox/extras/models/tags.py (+1 -1)
📝 netbox/extras/tests/test_filtersets.py (+5 -8)
📝 netbox/extras/tests/test_models.py (+8 -8)

📄 Description

Clean up for #14591 & #17841

Set the default value for weight fields to 1000. This allows more room to declare weights lower than the default value.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19155 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 4/11/2025 **Status:** ✅ Merged **Merged:** 4/11/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `feature` ← **Head:** `adjust-default-weights` --- ### 📝 Commits (2) - [`155932e`](https://github.com/netbox-community/netbox/commit/155932ea8e44f8db70b6066a530a2a8f6a5f214a) #14591, #17841: Adjust default weighting - [`30e2456`](https://github.com/netbox-community/netbox/commit/30e24561999aa59101f3f0a276c907c905d338e3) Fix tests ### 📊 Changes **6 files changed** (+17 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/migrations/0125_alter_tag_options_tag_weight.py` (+1 -1) 📝 `netbox/extras/migrations/0128_tableconfig.py` (+1 -1) 📝 `netbox/extras/models/models.py` (+1 -1) 📝 `netbox/extras/models/tags.py` (+1 -1) 📝 `netbox/extras/tests/test_filtersets.py` (+5 -8) 📝 `netbox/extras/tests/test_models.py` (+8 -8) </details> ### 📄 Description ### Clean up for #14591 & #17841 Set the default value for `weight` fields to 1000. This allows more room to declare weights lower than the default value. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:22:35 +01:00
adam closed this issue 2025-12-30 00:22:36 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15545