starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19156] [MERGED] 17170 ContactGroup Serializer nested and fix related objects #15544

New Issue
Closed
opened 2025-12-30 00:22:35 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:22:35 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19156
Author: @arthanson
Created: 4/11/2025
Status: ✅ Merged
Merged: 4/11/2025
Merged by: @jeremystretch

Base: feature ← Head: 17170-contact-groups-serializer

📝 Commits (1)

  • cb1d1ba 17170 ContactGroup Serializer nested and fix related objects

📊 Changes

2 files changed (+9 additions, -2 deletions)

View changed files

📝 netbox/tenancy/api/serializers_/contacts.py (+2 -1)
📝 netbox/tenancy/views.py (+7 -1)

📄 Description

Fixes: #17170

From review of NetBox v4.3 -

  • ContactSerializer group field should pass nested=True
  • Group should show number of assigned contacts under related objects

Monosnap newcgroup | NetBox 2025-04-11 10-25-49

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19156 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 4/11/2025 **Status:** ✅ Merged **Merged:** 4/11/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `17170-contact-groups-serializer` --- ### 📝 Commits (1) - [`cb1d1ba`](https://github.com/netbox-community/netbox/commit/cb1d1ba0bf7075215f7870249d16f9e695b02af3) 17170 ContactGroup Serializer nested and fix related objects ### 📊 Changes **2 files changed** (+9 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/tenancy/api/serializers_/contacts.py` (+2 -1) 📝 `netbox/tenancy/views.py` (+7 -1) </details> ### 📄 Description ### Fixes: #17170 From review of NetBox v4.3 - * ContactSerializer group field should pass nested=True * Group should show number of assigned contacts under related objects ![Monosnap newcgroup | NetBox 2025-04-11 10-25-49](https://github.com/user-attachments/assets/88450c8b-be38-4ade-ab52-7837a7010635) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:22:35 +01:00
adam closed this issue 2025-12-30 00:22:35 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15544
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?