starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19127] [MERGED] Fixes: #19038 Change ClusterView behaivour #15536

New Issue
Closed
opened 2025-12-30 00:22:33 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:22:33 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19127
Author: @renatoalmeidaoliveira
Created: 4/10/2025
Status: ✅ Merged
Merged: 4/14/2025
Merged by: @jeremystretch

Base: main ← Head: 19038-Change-ClusterView-behaivour

📝 Commits (1)

  • f4a7c07 Add GetRelatedModelsMixin to ClusterView

📊 Changes

2 files changed (+22 additions, -7 deletions)

View changed files

📝 netbox/templates/virtualization/cluster.html (+1 -0)
📝 netbox/virtualization/views.py (+21 -7)

📄 Description

Fixes: #19038 Change ClusterView behaivour

  • Add GetRelatedModelsMixin to ClusterView
  • Setup get_extra_context with related_models including VLANGroup
  • Add relatad_models panel to cluster.html template

Observations:

The Cluster model implement a child view for devices, and VMs but it can be redundant to have both the panel and those tabs, so removing those tab since the related_model already delivers a similar experience could be done.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19127 **Author:** [@renatoalmeidaoliveira](https://github.com/renatoalmeidaoliveira) **Created:** 4/10/2025 **Status:** ✅ Merged **Merged:** 4/14/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `19038-Change-ClusterView-behaivour` --- ### 📝 Commits (1) - [`f4a7c07`](https://github.com/netbox-community/netbox/commit/f4a7c07ab86714306034d00f76dade8bdd298af9) Add GetRelatedModelsMixin to ClusterView ### 📊 Changes **2 files changed** (+22 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `netbox/templates/virtualization/cluster.html` (+1 -0) 📝 `netbox/virtualization/views.py` (+21 -7) </details> ### 📄 Description ### Fixes: #19038 Change ClusterView behaivour - Add `GetRelatedModelsMixin` to `ClusterView` - Setup `get_extra_context` with `related_models` including `VLANGroup` - Add relatad_models panel to `cluster.html` template ### Observations: The `Cluster` model implement a child view for devices, and VMs but it can be redundant to have both the panel and those tabs, so removing those tab since the related_model already delivers a similar experience could be done. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:22:33 +01:00
adam closed this issue 2025-12-30 00:22:33 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15536
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?