starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19076] [MERGED] Closes #16058: Fix circular import involving register_model_view() #15517

New Issue
Closed
opened 2025-12-30 00:22:25 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:22:25 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19076
Author: @jeremystretch
Created: 4/3/2025
Status: ✅ Merged
Merged: 4/4/2025
Merged by: @arthanson

Base: feature ← Head: 16058-resolve-circular-import

📝 Commits (1)

  • 5379c1f Closes #16058: Fix circular import involving register_model_view()

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 netbox/netbox/models/features.py (+2 -1)

📄 Description

Fixes: #16058

Move the import of register_model_view() inside register_models(). Not ideal, but it allows us to import model feature mixins from users.models without disrupting the plugins API.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19076 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 4/3/2025 **Status:** ✅ Merged **Merged:** 4/4/2025 **Merged by:** [@arthanson](https://github.com/arthanson) **Base:** `feature` ← **Head:** `16058-resolve-circular-import` --- ### 📝 Commits (1) - [`5379c1f`](https://github.com/netbox-community/netbox/commit/5379c1f3b274da681aa5e8528e7afca2c38cc66e) Closes #16058: Fix circular import involving register_model_view() ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/models/features.py` (+2 -1) </details> ### 📄 Description ### Fixes: #16058 Move the import of `register_model_view()` inside `register_models()`. Not ideal, but it allows us to import model feature mixins from `users.models` without disrupting the plugins API. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:22:25 +01:00
adam closed this issue 2025-12-30 00:22:25 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15517
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?