starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19070] [MERGED] Closes #17166: Remove obsolete limit_choices_to argument from ForeignKey & M2M fields #15516

New Issue
Closed
opened 2025-12-30 00:22:25 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:22:25 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19070
Author: @jeremystretch
Created: 4/3/2025
Status: ✅ Merged
Merged: 4/7/2025
Merged by: @bctiemann

Base: feature ← Head: 17166-remove-limit_choices_to

📝 Commits (1)

  • d93d398 Closes #17166: Remove obsolete limit_choices_to argument from ForeignKey & M2M fields

📊 Changes

30 files changed (+2 additions, -224 deletions)

View changed files

📝 netbox/circuits/migrations/0047_circuittermination__termination.py (+0 -3)
📝 netbox/circuits/migrations/0051_virtualcircuit_group_assignment.py (+0 -2)
📝 netbox/circuits/models/circuits.py (+0 -2)
📝 netbox/dcim/migrations/0003_squashed_0130.py (+0 -44)
📝 netbox/dcim/migrations/0131_squashed_0159.py (+0 -52)
📝 netbox/dcim/migrations/0199_macaddress.py (+0 -7)
📝 netbox/dcim/models/cables.py (+0 -1)
📝 netbox/dcim/models/device_component_templates.py (+0 -1)
📝 netbox/dcim/models/device_components.py (+0 -1)
📝 netbox/dcim/models/devices.py (+0 -1)
📝 netbox/dcim/models/mixins.py (+0 -2)
📝 netbox/ipam/migrations/0001_squashed.py (+0 -6)
📝 netbox/ipam/migrations/0002_squashed_0046.py (+0 -7)
📝 netbox/ipam/migrations/0047_squashed_0053.py (+0 -8)
📝 netbox/ipam/migrations/0054_squashed_0067.py (+0 -8)
📝 netbox/ipam/migrations/0071_prefix_scope.py (+0 -1)
📝 netbox/ipam/models/ip.py (+0 -1)
📝 netbox/ipam/models/vlans.py (+0 -1)
📝 netbox/users/migrations/0001_squashed_0011.py (+0 -14)
📝 netbox/users/migrations/0007_objectpermission_update_object_types.py (+1 -18)

...and 10 more files

📄 Description

Fixes: #17166

  • Remove the limit_choices_to argument on all ForeignKey & ManyToMany fields.
  • Remove the argument from existing migrations as well, to avoid generating new migrations. (This field attribute has no impact on the database schema.)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19070 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 4/3/2025 **Status:** ✅ Merged **Merged:** 4/7/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `feature` ← **Head:** `17166-remove-limit_choices_to` --- ### 📝 Commits (1) - [`d93d398`](https://github.com/netbox-community/netbox/commit/d93d398afa1920c59a81c3272e0627bb6c38fa47) Closes #17166: Remove obsolete limit_choices_to argument from ForeignKey & M2M fields ### 📊 Changes **30 files changed** (+2 additions, -224 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/migrations/0047_circuittermination__termination.py` (+0 -3) 📝 `netbox/circuits/migrations/0051_virtualcircuit_group_assignment.py` (+0 -2) 📝 `netbox/circuits/models/circuits.py` (+0 -2) 📝 `netbox/dcim/migrations/0003_squashed_0130.py` (+0 -44) 📝 `netbox/dcim/migrations/0131_squashed_0159.py` (+0 -52) 📝 `netbox/dcim/migrations/0199_macaddress.py` (+0 -7) 📝 `netbox/dcim/models/cables.py` (+0 -1) 📝 `netbox/dcim/models/device_component_templates.py` (+0 -1) 📝 `netbox/dcim/models/device_components.py` (+0 -1) 📝 `netbox/dcim/models/devices.py` (+0 -1) 📝 `netbox/dcim/models/mixins.py` (+0 -2) 📝 `netbox/ipam/migrations/0001_squashed.py` (+0 -6) 📝 `netbox/ipam/migrations/0002_squashed_0046.py` (+0 -7) 📝 `netbox/ipam/migrations/0047_squashed_0053.py` (+0 -8) 📝 `netbox/ipam/migrations/0054_squashed_0067.py` (+0 -8) 📝 `netbox/ipam/migrations/0071_prefix_scope.py` (+0 -1) 📝 `netbox/ipam/models/ip.py` (+0 -1) 📝 `netbox/ipam/models/vlans.py` (+0 -1) 📝 `netbox/users/migrations/0001_squashed_0011.py` (+0 -14) 📝 `netbox/users/migrations/0007_objectpermission_update_object_types.py` (+1 -18) _...and 10 more files_ </details> ### 📄 Description ### Fixes: #17166 - Remove the `limit_choices_to` argument on all ForeignKey & ManyToMany fields. - Remove the argument from existing migrations as well, to avoid generating new migrations. (This field attribute has no impact on the database schema.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:22:25 +01:00
adam closed this issue 2025-12-30 00:22:26 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15516
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?