starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19029] [MERGED] Fixes: #18305 make contacts mixin available for plugins #15508

New Issue
Closed
opened 2025-12-30 00:22:22 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:22:22 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19029
Author: @renatoalmeidaoliveira
Created: 3/27/2025
Status: ✅ Merged
Merged: 4/1/2025
Merged by: @jeremystretch

Base: feature ← Head: 18305-Contacts-mixin-available-for-plugins

📝 Commits (9)

  • 8d2c190 Documentation update
  • e7ff0dd Create ObjectContactsView feature view, and upadte object_contact.html template
  • b822bd7 Removed models ContactView, and add ContactView registration
  • 2674e0e Move ObjectContactsView back to tenancy.views and using ObjectChildrenView
  • c3b4043 Documentation update
  • 2a2de36 simplify ObjectContactsView
  • f8bb764 Restore trailing line break
  • 5945b27 Move ObjectContactsView to netbox.views.generic.feature_views
  • 9eb0013 Clean up documentation

📊 Changes

9 files changed (+38 additions, -131 deletions)

View changed files

📝 docs/plugins/development/models.md (+2 -0)
📝 netbox/circuits/views.py (+0 -16)
📝 netbox/dcim/views.py (+0 -41)
📝 netbox/ipam/views.py (+0 -26)
📝 netbox/netbox/models/features.py (+7 -2)
📝 netbox/netbox/views/generic/feature_views.py (+28 -0)
📝 netbox/tenancy/views.py (+1 -24)
📝 netbox/virtualization/views.py (+0 -16)
📝 netbox/vpn/views.py (+0 -6)

📄 Description

Fixes: #18305 make contacts mixin available for plugins

  • Create ObjectContactsView feature view
  • Deleted tenancy.views.ObjectContactsView
  • Updated object_contacts.html removing object_children template
  • Added netbox.views.generic.ObjectContactsView use case to registry
  • Removed SiteContactsView
  • Removed ProviderContactsView
  • Removed ProviderAccountContactsView
  • Removed CircuitContactsView
  • Removed RegionContactsView
  • Removed SiteGroupContactsView
  • Removed LocationContactsView
  • Removed ManufacturerContactsView
  • Removed DeviceContactsView
  • Removed PowerPanelContactsView
  • Removed AggregateContactsView
  • Removed PrefixContactsView
  • Removed IPRangeContactsView
  • Removed IPAddressContactsView
  • Removed ServiceContactsView
  • Removed TenantContactsView
  • Removed ClusterGroupContactsView
  • Removed ClusterContactsView
  • Removed VirtualMachineContactsView
  • Removed TunnelGroupContactsView
  • Removed TunnelContactsView
  • Removed L2VPNContactsView
  • Updated docs/plugins/development/models.md adding ContactsMixin as available feature

I also tested with some plugins and its working when ContactsMixin is added to Model definition class

���� This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19029 **Author:** [@renatoalmeidaoliveira](https://github.com/renatoalmeidaoliveira) **Created:** 3/27/2025 **Status:** ✅ Merged **Merged:** 4/1/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `18305-Contacts-mixin-available-for-plugins` --- ### 📝 Commits (9) - [`8d2c190`](https://github.com/netbox-community/netbox/commit/8d2c1900b6fa0f6b5f22e2d9aa30acedab5b51cb) Documentation update - [`e7ff0dd`](https://github.com/netbox-community/netbox/commit/e7ff0ddff8db6d3c193dac9831f08c354082c0c6) Create ObjectContactsView feature view, and upadte object_contact.html template - [`b822bd7`](https://github.com/netbox-community/netbox/commit/b822bd7e639e5e214b317b84f1e2beec179547b8) Removed models ContactView, and add ContactView registration - [`2674e0e`](https://github.com/netbox-community/netbox/commit/2674e0e6a8db2252e9284c9e28bff200826315a8) Move ObjectContactsView back to tenancy.views and using ObjectChildrenView - [`c3b4043`](https://github.com/netbox-community/netbox/commit/c3b4043ebf338d6f95733a85ec95bfd0242bc327) Documentation update - [`2a2de36`](https://github.com/netbox-community/netbox/commit/2a2de3696b8381293d419716ffb553cb7886ea4d) simplify ObjectContactsView - [`f8bb764`](https://github.com/netbox-community/netbox/commit/f8bb764a7db503fed013ee2bfa0829bb41636570) Restore trailing line break - [`5945b27`](https://github.com/netbox-community/netbox/commit/5945b277408856d692f6a0245d1caa9b367f776a) Move ObjectContactsView to netbox.views.generic.feature_views - [`9eb0013`](https://github.com/netbox-community/netbox/commit/9eb00131388088d268cf3d0dd513479c58542790) Clean up documentation ### 📊 Changes **9 files changed** (+38 additions, -131 deletions) <details> <summary>View changed files</summary> 📝 `docs/plugins/development/models.md` (+2 -0) 📝 `netbox/circuits/views.py` (+0 -16) 📝 `netbox/dcim/views.py` (+0 -41) 📝 `netbox/ipam/views.py` (+0 -26) 📝 `netbox/netbox/models/features.py` (+7 -2) 📝 `netbox/netbox/views/generic/feature_views.py` (+28 -0) 📝 `netbox/tenancy/views.py` (+1 -24) 📝 `netbox/virtualization/views.py` (+0 -16) 📝 `netbox/vpn/views.py` (+0 -6) </details> ### 📄 Description ### Fixes: #18305 make contacts mixin available for plugins - Create `ObjectContactsView` feature view - Deleted `tenancy.views.ObjectContactsView` - Updated `object_contacts.html` removing `object_children` template - Added `netbox.views.generic.ObjectContactsView` use case to registry - Removed `SiteContactsView` - Removed `ProviderContactsView` - Removed `ProviderAccountContactsView` - Removed `CircuitContactsView` - Removed `RegionContactsView` - Removed `SiteGroupContactsView` - Removed `LocationContactsView` - Removed `ManufacturerContactsView` - Removed `DeviceContactsView` - Removed `PowerPanelContactsView` - Removed `AggregateContactsView` - Removed `PrefixContactsView` - Removed `IPRangeContactsView` - Removed `IPAddressContactsView` - Removed `ServiceContactsView` - Removed `TenantContactsView` - Removed `ClusterGroupContactsView` - Removed `ClusterContactsView` - Removed `VirtualMachineContactsView` - Removed `TunnelGroupContactsView` - Removed `TunnelContactsView` - Removed `L2VPNContactsView` - Updated `docs/plugins/development/models.md` adding `ContactsMixin` as available feature I also tested with some plugins and its working when `ContactsMixin` is added to `Model` definition class --- <sub>���� This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:22:22 +01:00
adam closed this issue 2025-12-30 00:22:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15508
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?