starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #19017] [CLOSED] Fixes: #18305 make contacts mixin available for plugins #15503

New Issue
Closed
opened 2025-12-30 00:22:21 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:22:21 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/19017
Author: @renatoalmeidaoliveira
Created: 3/27/2025
Status: ❌ Closed

Base: main ← Head: 18305-Make-ContactsMixin-available-for-plugins

📝 Commits (3)

  • eb4794d Created ObjectContactsView feature view, and refactor object_contacts.html template
  • db27160 Add generic.ObjectContactsView register, and remove Models ContactsView
  • ab92b4a documentation update

📊 Changes

10 files changed (+140 additions, -148 deletions)

View changed files

📝 docs/plugins/development/models.md (+2 -0)
📝 netbox/circuits/views.py (+0 -16)
📝 netbox/dcim/views.py (+1 -37)
📝 netbox/ipam/views.py (+0 -26)
📝 netbox/netbox/models/features.py (+4 -0)
📝 netbox/netbox/views/generic/feature_views.py (+78 -0)
📝 netbox/templates/tenancy/object_contacts.html (+54 -1)
📝 netbox/tenancy/views.py (+1 -36)
📝 netbox/virtualization/views.py (+0 -16)
📝 netbox/vpn/views.py (+0 -16)

📄 Description

Fixes: #18305 make contacts mixin available for plugins

  • Create ObjectContactsView feature view
  • Deleted tenancy.views.ObjectContactsView
  • Updated object_contacts.html removing object_children template
  • Added netbox.views.generic.ObjectContactsView use case to registry
  • Removed SiteContactsView
  • Removed ProviderContactsView
  • Removed ProviderAccountContactsView
  • Removed CircuitContactsView
  • Removed RegionContactsView
  • Removed SiteGroupContactsView
  • Removed LocationContactsView
  • Removed ManufacturerContactsView
  • Removed DeviceContactsView
  • Removed PowerPanelContactsView
  • Removed AggregateContactsView
  • Removed PrefixContactsView
  • Removed IPRangeContactsView
  • Removed IPAddressContactsView
  • Removed ServiceContactsView
  • Removed TenantContactsView
  • Removed ClusterGroupContactsView
  • Removed ClusterContactsView
  • Removed VirtualMachineContactsView
  • Removed TunnelGroupContactsView
  • Removed TunnelContactsView
  • Removed L2VPNContactsView
  • Updated docs/plugins/development/models.md adding ContactsMixin as available feature

I also tested with some plugins and its working when ContactsMixin is added to Model definition class

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/19017 **Author:** [@renatoalmeidaoliveira](https://github.com/renatoalmeidaoliveira) **Created:** 3/27/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `18305-Make-ContactsMixin-available-for-plugins` --- ### 📝 Commits (3) - [`eb4794d`](https://github.com/netbox-community/netbox/commit/eb4794ded7c10a71e4371346b2073c8953386a94) Created ObjectContactsView feature view, and refactor object_contacts.html template - [`db27160`](https://github.com/netbox-community/netbox/commit/db27160e424aa1bd7ee52cd33f91e4632ede2b94) Add generic.ObjectContactsView register, and remove Models ContactsView - [`ab92b4a`](https://github.com/netbox-community/netbox/commit/ab92b4a9374107d47373bc86f3f519ddb1ba2fe4) documentation update ### 📊 Changes **10 files changed** (+140 additions, -148 deletions) <details> <summary>View changed files</summary> 📝 `docs/plugins/development/models.md` (+2 -0) 📝 `netbox/circuits/views.py` (+0 -16) 📝 `netbox/dcim/views.py` (+1 -37) 📝 `netbox/ipam/views.py` (+0 -26) 📝 `netbox/netbox/models/features.py` (+4 -0) 📝 `netbox/netbox/views/generic/feature_views.py` (+78 -0) 📝 `netbox/templates/tenancy/object_contacts.html` (+54 -1) 📝 `netbox/tenancy/views.py` (+1 -36) 📝 `netbox/virtualization/views.py` (+0 -16) 📝 `netbox/vpn/views.py` (+0 -16) </details> ### 📄 Description ### Fixes: #18305 make contacts mixin available for plugins - Create `ObjectContactsView` feature view - Deleted `tenancy.views.ObjectContactsView` - Updated `object_contacts.html` removing `object_children` template - Added `netbox.views.generic.ObjectContactsView` use case to registry - Removed `SiteContactsView` - Removed `ProviderContactsView` - Removed `ProviderAccountContactsView` - Removed `CircuitContactsView` - Removed `RegionContactsView` - Removed `SiteGroupContactsView` - Removed `LocationContactsView` - Removed `ManufacturerContactsView` - Removed `DeviceContactsView` - Removed `PowerPanelContactsView` - Removed `AggregateContactsView` - Removed `PrefixContactsView` - Removed `IPRangeContactsView` - Removed `IPAddressContactsView` - Removed `ServiceContactsView` - Removed `TenantContactsView` - Removed `ClusterGroupContactsView` - Removed `ClusterContactsView` - Removed `VirtualMachineContactsView` - Removed `TunnelGroupContactsView` - Removed `TunnelContactsView` - Removed `L2VPNContactsView` - Updated `docs/plugins/development/models.md` adding `ContactsMixin` as available feature I also tested with some plugins and its working when `ContactsMixin` is added to `Model` definition class --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:22:21 +01:00
adam closed this issue 2025-12-30 00:22:21 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15503
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?