starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18948] [MERGED] Fixes: #18939 Allow ASN search by site-group #15488

New Issue
Closed
opened 2025-12-30 00:22:13 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:22:13 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18948
Author: @renatoalmeidaoliveira
Created: 3/19/2025
Status: ✅ Merged
Merged: 3/20/2025
Merged by: @jeremystretch

Base: main ← Head: 18939-Allow-ASN-search-by-site-group

📝 Commits (2)

  • cfef7e6 Add site_group and site_group_id to ASNFilterSet and ASNFilterForm
  • b403772 Implement ASNTestCase site_group test case

📊 Changes

3 files changed (+37 additions, -4 deletions)

View changed files

📝 netbox/ipam/filtersets.py (+13 -0)
📝 netbox/ipam/forms/filtersets.py (+6 -1)
📝 netbox/ipam/tests/test_filtersets.py (+18 -3)

📄 Description

Fixes: #18939 Allow ASN search by site-group

  • Add site_group and site_group_id to ASNFilterSet and ASNFilterForm

There're tests implemented in PrefixTestCase for site groups, should I implement similar tests cases for ASN site group too?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18948 **Author:** [@renatoalmeidaoliveira](https://github.com/renatoalmeidaoliveira) **Created:** 3/19/2025 **Status:** ✅ Merged **Merged:** 3/20/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `18939-Allow-ASN-search-by-site-group` --- ### 📝 Commits (2) - [`cfef7e6`](https://github.com/netbox-community/netbox/commit/cfef7e6f799cca0b9cf2846304b2cbcc54cc6ced) Add site_group and site_group_id to ASNFilterSet and ASNFilterForm - [`b403772`](https://github.com/netbox-community/netbox/commit/b4037725696ef475e8ad9f7f409ae953acb5c64b) Implement ASNTestCase site_group test case ### 📊 Changes **3 files changed** (+37 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/filtersets.py` (+13 -0) 📝 `netbox/ipam/forms/filtersets.py` (+6 -1) 📝 `netbox/ipam/tests/test_filtersets.py` (+18 -3) </details> ### 📄 Description ### Fixes: #18939 Allow ASN search by site-group - Add site_group and site_group_id to ASNFilterSet and ASNFilterForm There're tests implemented in `PrefixTestCase` for site groups, should I implement similar tests cases for ASN site group too? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:22:13 +01:00
adam closed this issue 2025-12-30 00:22:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15488
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?