starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18947] [MERGED] Fixes: #18933 VLANGroupFilterSet site_group field doesn't match VLANGroupFilterForm sitegroup field #15486

New Issue
Closed
opened 2025-12-30 00:22:13 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:22:13 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18947
Author: @renatoalmeidaoliveira
Created: 3/19/2025
Status: ✅ Merged
Merged: 3/20/2025
Merged by: @jnovinger

Base: main ← Head: 18933-VLANGroupFilterSet-site_group-field-doesn't-match-VLANGroupFilterForm-sitegroup-field

📝 Commits (1)

  • d4feb7f Fix sitegroup typo, VLANGroupFilterForm field didn't match between form and filterset

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 netbox/ipam/forms/filtersets.py (+2 -2)

📄 Description

Fixes: #18933 VLANGroupFilterSet site_group field doesn't match VLANGroupFilterForm sitegroup field

Fixes site_group field typo, it was defined as sitegroup in the FilterForm and as site_group in the FilterSet
Followed site_group pattern as it was already used in other places like:
ProviderFilterSet, CircuitTerminationFilterSet, LocationFilterSet and several others

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18947 **Author:** [@renatoalmeidaoliveira](https://github.com/renatoalmeidaoliveira) **Created:** 3/19/2025 **Status:** ✅ Merged **Merged:** 3/20/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `main` ← **Head:** `18933-VLANGroupFilterSet-site_group-field-doesn't-match-VLANGroupFilterForm-sitegroup-field` --- ### 📝 Commits (1) - [`d4feb7f`](https://github.com/netbox-community/netbox/commit/d4feb7f3cf00331f9af33e9668065705cc89d899) Fix sitegroup typo, VLANGroupFilterForm field didn't match between form and filterset ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/forms/filtersets.py` (+2 -2) </details> ### 📄 Description ### Fixes: #18933 VLANGroupFilterSet site_group field doesn't match VLANGroupFilterForm sitegroup field Fixes `site_group` field typo, it was defined as `sitegroup` in the `FilterForm` and as `site_group` in the `FilterSet` Followed `site_group` pattern as it was already used in other places like: `ProviderFilterSet`, `CircuitTerminationFilterSet`, `LocationFilterSet` and several others --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:22:13 +01:00
adam closed this issue 2025-12-30 00:22:13 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15486
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?